[GitHub] [orc] guiyanakuang commented on a change in pull request #907: ORC-992: Reached max repeat length, we can directly decide to use DELTA encoding

[GitBox <gi...@apache.org>]

guiyanakuang commented on a change in pull request #907:
URL: https://github.com/apache/orc/pull/907#discussion_r711829520



##########
File path: c++/src/RleEncoderV2.cc
##########
@@ -124,7 +124,8 @@ void RleEncoderV2::write(int64_t val) {
         }
 
         if (fixedRunLength == MAX_LITERAL_SIZE) {
-            determineEncoding(option);
+            option.encoding = DELTA;
+            option.isFixedDelta = true;

Review comment:
       The return on line 131 has ended the handling of the fixed delta run case. I think the comment on line 134 is not obsolete.  The following is exactly how to handle variable delta run.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org