[jira] [Commented] (HADOOP-10663) Path.getFileSystem should identify Windows drive (c:) like files and return the localFS

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HADOOP-10663?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14018733#comment-14018733 ] 

Hadoop QA commented on HADOOP-10663:
------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12648469/HADOOP-10663.1.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number of release audit warnings.

    {color:red}-1 core tests{color}.  The patch failed these unit tests in hadoop-common-project/hadoop-common:

                  org.apache.hadoop.net.TestNetUtils

    {color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/4010//testReport/
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/4010//console

This message is automatically generated.

> Path.getFileSystem should identify Windows drive (c:) like files and return the localFS
> ---------------------------------------------------------------------------------------
>
>                 Key: HADOOP-10663
>                 URL: https://issues.apache.org/jira/browse/HADOOP-10663
>             Project: Hadoop Common
>          Issue Type: Bug
>    Affects Versions: 3.0.0
>            Reporter: Remus Rusanu
>         Attachments: HADOOP-10663.1.patch
>
>
> While investigating the problem with MAPREDUCE-5912 I considered that the fact that asking a Windows specific Path to get its file system should not return the default FS, but the localFS. Specifically, I believe that Path.initialize should identify such names as belonging to the 'file://' scheme (when null) and so create appropriate URIs.
> I do not have the know-how to evaluate the bigger impact of such a change.



--
This message was sent by Atlassian JIRA
(v6.2#6252)