[GitHub] [arrow-rs] alamb commented on a change in pull request #1031: Extract method to drive PageIterator -> RecordReader

[GitBox <gi...@apache.org>]

alamb commented on a change in pull request #1031:
URL: https://github.com/apache/arrow-rs/pull/1031#discussion_r768125155



##########
File path: parquet/src/arrow/array_reader.rs
##########
@@ -100,6 +100,35 @@ pub trait ArrayReader {
     fn get_rep_levels(&self) -> Option<&[i16]>;
 }
 
+/// Uses `record_reader` to read up to `batch_size` records from `pages`
+///
+/// Returns the number of records read

Review comment:
       ```suggestion
   /// Returns the number of records read, which can be less than batch_size if 
   /// pages is exhausted. 
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org