You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Mike Percy (Code Review)" <ge...@cloudera.org> on 2019/01/30 20:49:26 UTC
[kudu-CR] binary artifact: generate properties file
Mike Percy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12314
Change subject: binary artifact: generate properties file
......................................................................
binary artifact: generate properties file
Generate a properties file so we can find the correct binary artifact on
the classpath at runtime. Also add documentation for the expected
properties in that file and their semantics in the build script.
Change-Id: Ic429fa87db5b839a0f00e929e706468c220d13c4
---
M build-support/build_mini_cluster_binaries.sh
1 file changed, 62 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/14/12314/1
--
To view, visit http://gerrit.cloudera.org:8080/12314
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic429fa87db5b839a0f00e929e706468c220d13c4
Gerrit-Change-Number: 12314
Gerrit-PatchSet: 1
Gerrit-Owner: Mike Percy <mp...@apache.org>
[kudu-CR] binary artifact: generate properties file
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12314 )
Change subject: binary artifact: generate properties file
......................................................................
binary artifact: generate properties file
Generate a properties file so we can find the correct binary artifact on
the classpath at runtime. Also add documentation for the expected
properties in that file and their semantics in the build script.
Change-Id: Ic429fa87db5b839a0f00e929e706468c220d13c4
Reviewed-on: http://gerrit.cloudera.org:8080/12314
Reviewed-by: Grant Henke <gr...@apache.org>
Tested-by: Grant Henke <gr...@apache.org>
---
M build-support/build_mini_cluster_binaries.sh
1 file changed, 63 insertions(+), 1 deletion(-)
Approvals:
Grant Henke: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/12314
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic429fa87db5b839a0f00e929e706468c220d13c4
Gerrit-Change-Number: 12314
Gerrit-PatchSet: 4
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Brian McDevitt <br...@phdata.io>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
[kudu-CR] binary artifact: generate properties file
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/12314 )
Change subject: binary artifact: generate properties file
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/12314/1/build-support/build_mini_cluster_binaries.sh
File build-support/build_mini_cluster_binaries.sh:
http://gerrit.cloudera.org:8080/#/c/12314/1/build-support/build_mini_cluster_binaries.sh@63
PS1, Line 63: # artifact.prefix=apache-kudu-1.8.0
> My name change patch changed this to `kudu-binary-1.9.0-SNAPSHOT-osx-x86_64
I used kudu-binary instead of apache-kudu for two reasons:
1. The apache part isn't really necessary and doesn't match our other artifacts.
2. The -binary part seams like a nice short artifact name that shows what is in the jar.
--
To view, visit http://gerrit.cloudera.org:8080/12314
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic429fa87db5b839a0f00e929e706468c220d13c4
Gerrit-Change-Number: 12314
Gerrit-PatchSet: 1
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Brian McDevitt <br...@phdata.io>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Wed, 30 Jan 2019 20:57:24 +0000
Gerrit-HasComments: Yes
[kudu-CR] binary artifact: generate properties file
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Hello Brian McDevitt, Kudu Jenkins, Adar Dembo, Grant Henke,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/12314
to look at the new patch set (#2).
Change subject: binary artifact: generate properties file
......................................................................
binary artifact: generate properties file
Generate a properties file so we can find the correct binary artifact on
the classpath at runtime. Also add documentation for the expected
properties in that file and their semantics in the build script.
Change-Id: Ic429fa87db5b839a0f00e929e706468c220d13c4
---
M build-support/build_mini_cluster_binaries.sh
1 file changed, 63 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/14/12314/2
--
To view, visit http://gerrit.cloudera.org:8080/12314
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ic429fa87db5b839a0f00e929e706468c220d13c4
Gerrit-Change-Number: 12314
Gerrit-PatchSet: 2
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Brian McDevitt <br...@phdata.io>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
[kudu-CR] binary artifact: generate properties file
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/12314 )
Change subject: binary artifact: generate properties file
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/12314
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic429fa87db5b839a0f00e929e706468c220d13c4
Gerrit-Change-Number: 12314
Gerrit-PatchSet: 3
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Brian McDevitt <br...@phdata.io>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Wed, 30 Jan 2019 22:35:44 +0000
Gerrit-HasComments: No
[kudu-CR] binary artifact: generate properties file
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/12314 )
Change subject: binary artifact: generate properties file
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/12314/1/build-support/build_mini_cluster_binaries.sh
File build-support/build_mini_cluster_binaries.sh:
http://gerrit.cloudera.org:8080/#/c/12314/1/build-support/build_mini_cluster_binaries.sh@63
PS1, Line 63: # artifact.prefix=apache-kudu-1.8.0
My name change patch changed this to `kudu-binary-1.9.0-SNAPSHOT-osx-x86_64`.
That is pretty lengthy though. Perhaps this should be decoupled from the artifact name.
--
To view, visit http://gerrit.cloudera.org:8080/12314
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic429fa87db5b839a0f00e929e706468c220d13c4
Gerrit-Change-Number: 12314
Gerrit-PatchSet: 1
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Brian McDevitt <br...@phdata.io>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Wed, 30 Jan 2019 20:55:39 +0000
Gerrit-HasComments: Yes
[kudu-CR] binary artifact: generate properties file
Posted by "Brian McDevitt (Code Review)" <ge...@cloudera.org>.
Brian McDevitt has posted comments on this change. ( http://gerrit.cloudera.org:8080/12314 )
Change subject: binary artifact: generate properties file
......................................................................
Patch Set 1: Code-Review+1
Looks good.
--
To view, visit http://gerrit.cloudera.org:8080/12314
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic429fa87db5b839a0f00e929e706468c220d13c4
Gerrit-Change-Number: 12314
Gerrit-PatchSet: 1
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Brian McDevitt <br...@phdata.io>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Wed, 30 Jan 2019 20:55:20 +0000
Gerrit-HasComments: No
[kudu-CR] binary artifact: generate properties file
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/12314 )
Change subject: binary artifact: generate properties file
......................................................................
Patch Set 3: Verified+1
I ran on my Mac and the included properties file contained:
```
format.version=1
artifact.os=osx
artifact.arch=x86_64
artifact.prefix=kudu-binary-1.9.0-SNAPSHOT-osx-x86_64
artifact.version=1.9.0-SNAPSHOT
```
--
To view, visit http://gerrit.cloudera.org:8080/12314
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic429fa87db5b839a0f00e929e706468c220d13c4
Gerrit-Change-Number: 12314
Gerrit-PatchSet: 3
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Brian McDevitt <br...@phdata.io>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Wed, 30 Jan 2019 22:38:10 +0000
Gerrit-HasComments: No
[kudu-CR] binary artifact: generate properties file
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12314 )
Change subject: binary artifact: generate properties file
......................................................................
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/12314/1/build-support/build_mini_cluster_binaries.sh
File build-support/build_mini_cluster_binaries.sh:
http://gerrit.cloudera.org:8080/#/c/12314/1/build-support/build_mini_cluster_binaries.sh@38
PS1, Line 38: # META-INF/apache-kudu-test-binary.properties
This should be updated to reflect the infixes that vary (i.e. arch, platform, etc.)
http://gerrit.cloudera.org:8080/#/c/12314/1/build-support/build_mini_cluster_binaries.sh@137
PS1, Line 137: PROP_FILE="$PROP_DIR/apache-kudu-test-binary.properties"
Would it be possible to extract the filename, OS, and arch from ARTIFACT_NAME (i.e. the output of the python script)?
--
To view, visit http://gerrit.cloudera.org:8080/12314
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic429fa87db5b839a0f00e929e706468c220d13c4
Gerrit-Change-Number: 12314
Gerrit-PatchSet: 1
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Brian McDevitt <br...@phdata.io>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Wed, 30 Jan 2019 20:59:57 +0000
Gerrit-HasComments: Yes
[kudu-CR] binary artifact: generate properties file
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has removed a vote on this change.
Change subject: binary artifact: generate properties file
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/12314
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: Ic429fa87db5b839a0f00e929e706468c220d13c4
Gerrit-Change-Number: 12314
Gerrit-PatchSet: 3
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Brian McDevitt <br...@phdata.io>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
[kudu-CR] binary artifact: generate properties file
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/12314 )
Change subject: binary artifact: generate properties file
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/12314/1/build-support/build_mini_cluster_binaries.sh
File build-support/build_mini_cluster_binaries.sh:
http://gerrit.cloudera.org:8080/#/c/12314/1/build-support/build_mini_cluster_binaries.sh@137
PS1, Line 137: PROP_FILE="$PROP_DIR/apache-kudu-test-binary.properties"
> I'm disinclined to attempt that because the delimiter ("-") is not unique s
Because it is a single process that creates both, I am okay with this.
--
To view, visit http://gerrit.cloudera.org:8080/12314
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic429fa87db5b839a0f00e929e706468c220d13c4
Gerrit-Change-Number: 12314
Gerrit-PatchSet: 1
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Brian McDevitt <br...@phdata.io>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Wed, 30 Jan 2019 22:34:27 +0000
Gerrit-HasComments: Yes
[kudu-CR] binary artifact: generate properties file
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/12314 )
Change subject: binary artifact: generate properties file
......................................................................
Patch Set 1:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/12314/1/build-support/build_mini_cluster_binaries.sh
File build-support/build_mini_cluster_binaries.sh:
http://gerrit.cloudera.org:8080/#/c/12314/1/build-support/build_mini_cluster_binaries.sh@38
PS1, Line 38: # META-INF/apache-kudu-test-binary.properties
> This should be updated to reflect the infixes that vary (i.e. arch, platfor
Nah, that's the purpose of the contents of the file. We can easily collect all of them on the classpath and filter based on the properties.
http://gerrit.cloudera.org:8080/#/c/12314/1/build-support/build_mini_cluster_binaries.sh@63
PS1, Line 63: # artifact.prefix=apache-kudu-1.8.0
> I used kudu-binary instead of apache-kudu for two reasons:
Done
http://gerrit.cloudera.org:8080/#/c/12314/1/build-support/build_mini_cluster_binaries.sh@137
PS1, Line 137: PROP_FILE="$PROP_DIR/apache-kudu-test-binary.properties"
> Would it be possible to extract the filename, OS, and arch from ARTIFACT_NA
I'm disinclined to attempt that because the delimiter ("-") is not unique since ARTIFACT_VERSION may include "-SNAPSHOT".
--
To view, visit http://gerrit.cloudera.org:8080/12314
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic429fa87db5b839a0f00e929e706468c220d13c4
Gerrit-Change-Number: 12314
Gerrit-PatchSet: 1
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Brian McDevitt <br...@phdata.io>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Wed, 30 Jan 2019 22:33:17 +0000
Gerrit-HasComments: Yes