You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "jakubrauch (via GitHub)" <gi...@apache.org> on 2023/04/27 19:49:25 UTC
[GitHub] [beam] jakubrauch opened a new pull request, #25913: Add synchronized to getExtensionRegistry() lazy initialization
jakubrauch opened a new pull request, #25913:
URL: https://github.com/apache/beam/pull/25913
**Please** add a meaningful description for your change here
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/get-started-contributing/#make-the-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kennknowles commented on pull request #25913: Add synchronized to getExtensionRegistry() lazy initialization
Posted by "kennknowles (via GitHub)" <gi...@apache.org>.
kennknowles commented on PR #25913:
URL: https://github.com/apache/beam/pull/25913#issuecomment-1541190044
I'll merge when it is confirmed green (TBH I'm not 100% sure the testing is adequate to catch problems with a change like this)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kennknowles commented on pull request #25913: Add synchronized to getExtensionRegistry() lazy initialization
Posted by "kennknowles (via GitHub)" <gi...@apache.org>.
kennknowles commented on PR #25913:
URL: https://github.com/apache/beam/pull/25913#issuecomment-1541200842
Run RAT PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] commented on pull request #25913: Add synchronized to getExtensionRegistry() lazy initialization
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #25913:
URL: https://github.com/apache/beam/pull/25913#issuecomment-1526580673
## [Codecov](https://codecov.io/gh/apache/beam/pull/25913?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#25913](https://codecov.io/gh/apache/beam/pull/25913?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (5520527) into [master](https://codecov.io/gh/apache/beam/commit/5aafb125ced601b16bf3e6a8c76d3a6962292b66?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (5aafb12) will **increase** coverage by `0.01%`.
> The diff coverage is `n/a`.
> :exclamation: Current head 5520527 differs from pull request most recent head 36b5203. Consider uploading reports for the commit 36b5203 to get more accurate results
```diff
@@ Coverage Diff @@
## master #25913 +/- ##
==========================================
+ Coverage 81.10% 81.12% +0.01%
==========================================
Files 469 469
Lines 67294 67294
==========================================
+ Hits 54580 54589 +9
+ Misses 12714 12705 -9
```
| Flag | Coverage Δ | |
|---|---|---|
| python | `81.12% <ø> (+0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
[see 7 files with indirect coverage changes](https://codecov.io/gh/apache/beam/pull/25913/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #25913: Add synchronized to getExtensionRegistry() lazy initialization
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #25913:
URL: https://github.com/apache/beam/pull/25913#issuecomment-1541190381
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #25913: Add synchronized to getExtensionRegistry() lazy initialization
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #25913:
URL: https://github.com/apache/beam/pull/25913#issuecomment-1512991302
Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment `assign to next reviewer`:
R: @robertwb for label java.
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kennknowles commented on pull request #25913: Add synchronized to getExtensionRegistry() lazy initialization
Posted by "kennknowles (via GitHub)" <gi...@apache.org>.
kennknowles commented on PR #25913:
URL: https://github.com/apache/beam/pull/25913#issuecomment-1541189713
R: @kennknowles
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kennknowles merged pull request #25913: Add synchronized to getExtensionRegistry() lazy initialization
Posted by "kennknowles (via GitHub)" <gi...@apache.org>.
kennknowles merged PR #25913:
URL: https://github.com/apache/beam/pull/25913
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kennknowles commented on a diff in pull request #25913: Add synchronized to getExtensionRegistry() lazy initialization
Posted by "kennknowles (via GitHub)" <gi...@apache.org>.
kennknowles commented on code in PR #25913:
URL: https://github.com/apache/beam/pull/25913#discussion_r1179537188
##########
sdks/java/extensions/protobuf/src/main/java/org/apache/beam/sdk/extensions/protobuf/ProtoCoder.java:
##########
@@ -275,7 +279,7 @@ public ExtensionRegistry getExtensionRegistry() {
final Set<Class<?>> extensionHostClasses;
// Transient fields that are lazy initialized and then memoized.
- private transient ExtensionRegistry memoizedExtensionRegistry;
+ private transient volatile ExtensionRegistry memoizedExtensionRegistry;
Review Comment:
Marking it volatile is redundant with synchronization, right?
##########
sdks/java/extensions/protobuf/src/main/java/org/apache/beam/sdk/extensions/protobuf/ProtoCoder.java:
##########
@@ -247,17 +247,21 @@ public Set<Class<?>> getExtensionHosts() {
*/
public ExtensionRegistry getExtensionRegistry() {
if (memoizedExtensionRegistry == null) {
- ExtensionRegistry registry = ExtensionRegistry.newInstance();
- for (Class<?> extensionHost : extensionHostClasses) {
- try {
- extensionHost
- .getDeclaredMethod("registerAllExtensions", ExtensionRegistry.class)
- .invoke(null, registry);
- } catch (IllegalAccessException | InvocationTargetException | NoSuchMethodException e) {
- throw new IllegalStateException(e);
+ synchronized (this) {
Review Comment:
We chatted off the PR and I understand this is to remove the benign race so that concurrency analyzers are happy.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #25913: Add synchronized to getExtensionRegistry() lazy initialization
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #25913:
URL: https://github.com/apache/beam/pull/25913#issuecomment-1477950310
Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`:
R: @kennknowles for label java.
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
The PR bot will only process comments in the main thread (not review comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #25913: Add synchronized to getExtensionRegistry() lazy initialization
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #25913:
URL: https://github.com/apache/beam/pull/25913#issuecomment-1494212727
Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment `assign to next reviewer`:
R: @lukecwik for label java.
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kennknowles commented on a diff in pull request #25913: Add synchronized to getExtensionRegistry() lazy initialization
Posted by "kennknowles (via GitHub)" <gi...@apache.org>.
kennknowles commented on code in PR #25913:
URL: https://github.com/apache/beam/pull/25913#discussion_r1179535771
##########
sdks/java/extensions/protobuf/src/main/java/org/apache/beam/sdk/extensions/protobuf/ProtoCoder.java:
##########
@@ -247,17 +247,21 @@ public Set<Class<?>> getExtensionHosts() {
*/
public ExtensionRegistry getExtensionRegistry() {
if (memoizedExtensionRegistry == null) {
- ExtensionRegistry registry = ExtensionRegistry.newInstance();
- for (Class<?> extensionHost : extensionHostClasses) {
- try {
- extensionHost
- .getDeclaredMethod("registerAllExtensions", ExtensionRegistry.class)
- .invoke(null, registry);
- } catch (IllegalAccessException | InvocationTargetException | NoSuchMethodException e) {
- throw new IllegalStateException(e);
+ synchronized (this) {
Review Comment:
why is this necessary?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] jakubrauch closed pull request #25913: Add synchronized to getExtensionRegistry() lazy initialization
Posted by "jakubrauch (via GitHub)" <gi...@apache.org>.
jakubrauch closed pull request #25913: Add synchronized to getExtensionRegistry() lazy initialization
URL: https://github.com/apache/beam/pull/25913
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #25913: Add synchronized to getExtensionRegistry() lazy initialization
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #25913:
URL: https://github.com/apache/beam/pull/25913#issuecomment-1508412864
Reminder, please take a look at this pr: @lukecwik
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #25913: Add synchronized to getExtensionRegistry() lazy initialization
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #25913:
URL: https://github.com/apache/beam/pull/25913#issuecomment-1523317544
Reminder, please take a look at this pr: @robertwb
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] jakubrauch commented on a diff in pull request #25913: Add synchronized to getExtensionRegistry() lazy initialization
Posted by "jakubrauch (via GitHub)" <gi...@apache.org>.
jakubrauch commented on code in PR #25913:
URL: https://github.com/apache/beam/pull/25913#discussion_r1179618259
##########
sdks/java/extensions/protobuf/src/main/java/org/apache/beam/sdk/extensions/protobuf/ProtoCoder.java:
##########
@@ -275,7 +279,7 @@ public ExtensionRegistry getExtensionRegistry() {
final Set<Class<?>> extensionHostClasses;
// Transient fields that are lazy initialized and then memoized.
- private transient ExtensionRegistry memoizedExtensionRegistry;
+ private transient volatile ExtensionRegistry memoizedExtensionRegistry;
Review Comment:
Analyzer hinted at changing it to volatile after the synchronization. I suspect the analyzer worries it could still potentially read stale registry within the synchronization block.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #25913: Add synchronized to getExtensionRegistry() lazy initialization
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #25913:
URL: https://github.com/apache/beam/pull/25913#issuecomment-1488490239
Reminder, please take a look at this pr: @kennknowles
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #25913: Add synchronized to getExtensionRegistry() lazy initialization
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #25913:
URL: https://github.com/apache/beam/pull/25913#issuecomment-1537129306
Reminder, please take a look at this pr: @robertwb
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org