You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/08/04 19:42:06 UTC

[GitHub] [spark] mridulm commented on pull request #36200: [SPARK-38909][CORE][YARN] Encapsulate `LevelDB` used by `ExternalShuffleBlockResolver`,`YarnShuffleService` and `RemoteBlockPushResolver` as `DB`

mridulm commented on PR #36200:
URL: https://github.com/apache/spark/pull/36200#issuecomment-1205694855

   > @dongjoon-hyun @mridulm Conflict is resolved and GA passed. But I think we should make sure that [SPARK-38888](https://issues.apache.org/jira/browse/SPARK-38888) is worth to do before reviewing, because this pr is the pre-work of [SPARK-38888](https://issues.apache.org/jira/browse/SPARK-38888).
   
   I agree with @dongjoon-hyun's assessment in the jira, and I dont have strong opinion.
   If rest of the codebase is moving towards an abstraction for db, I would prefer we did the same for yarn shuffle as well though from a consistency point of view.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org