You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@activemq.apache.org by GitBox <gi...@apache.org> on 2020/01/16 07:48:51 UTC
[GitHub] [activemq-artemis] franz1981 opened a new pull request #2942:
NO-JIRA DescribeJournal isn't correctly counting msg
franz1981 opened a new pull request #2942: NO-JIRA DescribeJournal isn't correctly counting msg
URL: https://github.com/apache/activemq-artemis/pull/2942
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [activemq-artemis] asfgit closed pull request #2942: ARTEMIS-2599
DescribeJournal isn't correctly counting surviving msg
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #2942: ARTEMIS-2599 DescribeJournal isn't correctly counting surviving msg
URL: https://github.com/apache/activemq-artemis/pull/2942
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [activemq-artemis] clebertsuconic commented on issue #2942: NO-JIRA
DescribeJournal isn't correctly counting msg
Posted by GitBox <gi...@apache.org>.
clebertsuconic commented on issue #2942: NO-JIRA DescribeJournal isn't correctly counting msg
URL: https://github.com/apache/activemq-artemis/pull/2942#issuecomment-575150910
the integer boxing.. I don't think it was a big deal as this is a reporting tool only. not really intended for high performance. although it was written that way just because I first did it to solve / debug an issue, commited on the repo and it's there until today.
Now, if there are issues on the counter, it warrants a JIRA.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [activemq-artemis] franz1981 edited a comment on issue #2942:
ARTEMIS-2599 DescribeJournal isn't correctly counting surviving msg
Posted by GitBox <gi...@apache.org>.
franz1981 edited a comment on issue #2942: ARTEMIS-2599 DescribeJournal isn't correctly counting surviving msg
URL: https://github.com/apache/activemq-artemis/pull/2942#issuecomment-575508485
@clebertsuconic done!
> the integer boxing.. I don't think it was a big deal as this is a reporting tool only
Not a big deal indeed, but this tool requires some memory to be allocated depending on the amount of surviving records: given that reducing the boxed `Integer`s wasn't an impactfull code change, I've thought to bring that in too.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [activemq-artemis] franz1981 commented on issue #2942: ARTEMIS-2599
DescribeJournal isn't correctly counting surviving msg
Posted by GitBox <gi...@apache.org>.
franz1981 commented on issue #2942: ARTEMIS-2599 DescribeJournal isn't correctly counting surviving msg
URL: https://github.com/apache/activemq-artemis/pull/2942#issuecomment-575508485
@clebertsuconic done!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [activemq-artemis] clebertsuconic commented on issue #2942: NO-JIRA
DescribeJournal isn't correctly counting msg
Posted by GitBox <gi...@apache.org>.
clebertsuconic commented on issue #2942: NO-JIRA DescribeJournal isn't correctly counting msg
URL: https://github.com/apache/activemq-artemis/pull/2942#issuecomment-575153695
@franz1981 can you open a JIRA for this one and amend your commit?. this one would be nice on the release notes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [activemq-artemis] franz1981 edited a comment on issue #2942:
ARTEMIS-2599 DescribeJournal isn't correctly counting surviving msg
Posted by GitBox <gi...@apache.org>.
franz1981 edited a comment on issue #2942: ARTEMIS-2599 DescribeJournal isn't correctly counting surviving msg
URL: https://github.com/apache/activemq-artemis/pull/2942#issuecomment-575508485
@clebertsuconic done!
> the integer boxing.. I don't think it was a big deal as this is a reporting tool only
Not a big deal indeed, but this tool requires some memory to be allocated depending on the amount of surviving records: given that reducing the amount of boxed `Integer` wasn't an impactfull code change, I've thought to bring that in too.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services