[GitHub] [hbase] saintstack commented on a change in pull request #1751: HBASE-24409: Exposing a function in HBase WALKey to set the table name

[GitBox <gi...@apache.org>]

saintstack commented on a change in pull request #1751:
URL: https://github.com/apache/hbase/pull/1751#discussion_r432153953



##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/wal/WALKey.java
##########
@@ -57,6 +57,14 @@ default long estimatedSerializedSizeOf() {
    */
   TableName getTableName();
 
+  /**
+   * set the table name for WALKey. This is mainly for the purpose of
+   * when we want to change the table name in the WALKey.
+   * For example:
+   * replicating across different table names in two different clusters
+   */
+  void setTableName(TableName tableName);

Review comment:
       WALKey only has getters. It doesn't say it is immutable in the class comment but it should.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org