You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@trafficserver.apache.org by "ywkaras (via GitHub)" <gi...@apache.org> on 2024/04/26 22:21:29 UTC
[PR] Remove obsolete debug output calls in 23 source files. [trafficserver]
ywkaras opened a new pull request, #11298:
URL: https://github.com/apache/trafficserver/pull/11298
In the src/proxy tree.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove obsolete debug output calls in 23 source files. [trafficserver]
Posted by "zwoop (via GitHub)" <gi...@apache.org>.
zwoop commented on code in PR #11298:
URL: https://github.com/apache/trafficserver/pull/11298#discussion_r1590457637
##########
src/proxy/hdrs/HdrToken.cc:
##########
@@ -168,7 +172,7 @@ static HdrTokenTypeBinding _hdrtoken_strs_type_initializers[] = {
{(char *)nullptr, static_cast<HdrTokenType>(0)},
};
-static HdrTokenFieldInfo _hdrtoken_strs_field_initializers[] = {
+HdrTokenFieldInfo _hdrtoken_strs_field_initializers[] = {
Review Comment:
We hate static ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove obsolete debug output calls in 23 source files. [trafficserver]
Posted by "zwoop (via GitHub)" <gi...@apache.org>.
zwoop merged PR #11298:
URL: https://github.com/apache/trafficserver/pull/11298
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove obsolete debug output calls in 23 source files. [trafficserver]
Posted by "zwoop (via GitHub)" <gi...@apache.org>.
zwoop commented on code in PR #11298:
URL: https://github.com/apache/trafficserver/pull/11298#discussion_r1590457903
##########
src/proxy/http2/HPACK.cc:
##########
@@ -208,7 +211,7 @@ hpack_field_is_literal(HpackField ftype)
// Try not to use memcmp(sv, sv) and strncasecmp(sv, sv) because we don't care which value comes first on a dictionary.
// Return immediately if the lengths of given strings don't match.
// Also, we noticed with profiling that taking char* and int was more performant than taking std::string_view.
-static inline bool
Review Comment:
Poor static.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove obsolete debug output calls in 23 source files. [trafficserver]
Posted by "ywkaras (via GitHub)" <gi...@apache.org>.
ywkaras commented on PR #11298:
URL: https://github.com/apache/trafficserver/pull/11298#issuecomment-2080246127
[approve ci autest]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove obsolete debug output calls in 23 source files. [trafficserver]
Posted by "zwoop (via GitHub)" <gi...@apache.org>.
zwoop commented on code in PR #11298:
URL: https://github.com/apache/trafficserver/pull/11298#discussion_r1590457481
##########
src/proxy/hdrs/HdrToken.cc:
##########
@@ -47,7 +51,7 @@
/ericb
*/
-static const char *_hdrtoken_strs[] = {
+const char *_hdrtoken_strs[] = {
Review Comment:
Why eliminate static here ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove obsolete debug output calls in 23 source files. [trafficserver]
Posted by "cmcfarlen (via GitHub)" <gi...@apache.org>.
cmcfarlen commented on PR #11298:
URL: https://github.com/apache/trafficserver/pull/11298#issuecomment-2114928446
Cherry-picked to v10.0.x
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove obsolete debug output calls in 23 source files. [trafficserver]
Posted by "zwoop (via GitHub)" <gi...@apache.org>.
zwoop commented on code in PR #11298:
URL: https://github.com/apache/trafficserver/pull/11298#discussion_r1590457667
##########
src/proxy/hdrs/URL.cc:
##########
@@ -93,9 +93,16 @@ int URL_LEN_MMS;
int URL_LEN_MMSU;
int URL_LEN_MMST;
+namespace
+{
// Whether we should implement url_CryptoHash_get() using url_CryptoHash_get_fast(). Note that
// url_CryptoHash_get_fast() does NOT produce the same result as url_CryptoHash_get_general().
-static int url_hash_method = 0;
+int url_hash_method = 0;
Review Comment:
I miss static
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove obsolete debug output calls in 23 source files. [trafficserver]
Posted by "zwoop (via GitHub)" <gi...@apache.org>.
zwoop commented on code in PR #11298:
URL: https://github.com/apache/trafficserver/pull/11298#discussion_r1590457573
##########
src/proxy/hdrs/HdrToken.cc:
##########
@@ -118,7 +122,7 @@ static const char *_hdrtoken_strs[] = {
// RFC-7932
"br"};
-static HdrTokenTypeBinding _hdrtoken_strs_type_initializers[] = {
+HdrTokenTypeBinding _hdrtoken_strs_type_initializers[] = {
Review Comment:
Why not static ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove obsolete debug output calls in 23 source files. [trafficserver]
Posted by "ywkaras (via GitHub)" <gi...@apache.org>.
ywkaras commented on PR #11298:
URL: https://github.com/apache/trafficserver/pull/11298#issuecomment-2080204478
[approve ci rat]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org