You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "justinpark (via GitHub)" <gi...@apache.org> on 2023/03/28 21:11:50 UTC
[GitHub] [superset] justinpark opened a new pull request, #23515: fix(plugin-chart-table): Invalid d3Formatter on String column
justinpark opened a new pull request, #23515:
URL: https://github.com/apache/superset/pull/23515
### SUMMARY
regression from #17336
column_config applied the `d3NumberFormat` to all columns including STRING column, the string column value has been converted to 'NaN' due to invalid formatter.
This commit replaces `numberFormat` to apply for Number column only.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
After:
<img width="314" alt="Screenshot 2023-03-28 at 2 06 15 PM" src="https://user-images.githubusercontent.com/1392866/228367625-d9f84993-c4aa-4432-96da-95d1e7e7c773.png">
Before:
<img width="314" alt="Screenshot 2023-03-28 at 2 05 27 PM" src="https://user-images.githubusercontent.com/1392866/228367631-f1e8e9a6-d42c-4c74-8633-ba9ac1a428e2.png">
### TESTING INSTRUCTIONS
Create a Table chart and apply the `d3NumberFormat`
### ADDITIONAL INFORMATION
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
cc: @ktmud @michael-s-molina
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #23515: fix(plugin-chart-table): Invalid d3Formatter on String column
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #23515:
URL: https://github.com/apache/superset/pull/23515#issuecomment-1487653970
## [Codecov](https://codecov.io/gh/apache/superset/pull/23515?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#23515](https://codecov.io/gh/apache/superset/pull/23515?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (870dcbb) into [master](https://codecov.io/gh/apache/superset/commit/21578f74b75e630111c0fab574888f43f3235ce3?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (21578f7) will **increase** coverage by `0.02%`.
> The diff coverage is `33.33%`.
> :exclamation: Current head 870dcbb differs from pull request most recent head c647cf0. Consider uploading reports for the commit c647cf0 to get more accurate results
```diff
@@ Coverage Diff @@
## master #23515 +/- ##
==========================================
+ Coverage 67.63% 67.65% +0.02%
==========================================
Files 1910 1910
Lines 73746 73746
Branches 7987 7987
==========================================
+ Hits 49876 49892 +16
+ Misses 21829 21813 -16
Partials 2041 2041
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `53.85% <33.33%> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/23515?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...t-ui-chart-controls/src/shared-controls/mixins.tsx](https://codecov.io/gh/apache/superset/pull/23515?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL3NoYXJlZC1jb250cm9scy9taXhpbnMudHN4) | `16.66% <ø> (ø)` | |
| [...s/superset-ui-core/src/components/SafeMarkdown.tsx](https://codecov.io/gh/apache/superset/pull/23515?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvY29tcG9uZW50cy9TYWZlTWFya2Rvd24udHN4) | `66.66% <ø> (ø)` | |
| [...plugins/legacy-plugin-chart-heatmap/src/Heatmap.js](https://codecov.io/gh/apache/superset/pull/23515?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LWhlYXRtYXAvc3JjL0hlYXRtYXAuanM=) | `0.00% <0.00%> (ø)` | |
| [.../src/explore/components/ControlPanelsContainer.tsx](https://codecov.io/gh/apache/superset/pull/23515?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9Db250cm9sUGFuZWxzQ29udGFpbmVyLnRzeA==) | `69.76% <0.00%> (ø)` | |
| [...d/plugins/plugin-chart-table/src/transformProps.ts](https://codecov.io/gh/apache/superset/pull/23515?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9wbHVnaW4tY2hhcnQtdGFibGUvc3JjL3RyYW5zZm9ybVByb3BzLnRz) | `64.83% <100.00%> (+0.39%)` | :arrow_up: |
... and [5 files with indirect coverage changes](https://codecov.io/gh/apache/superset/pull/23515/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] justinpark merged pull request #23515: fix(plugin-chart-table): Invalid d3Formatter on String column
Posted by "justinpark (via GitHub)" <gi...@apache.org>.
justinpark merged PR #23515:
URL: https://github.com/apache/superset/pull/23515
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org