You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by daan Hoogland <da...@gmail.com> on 2013/08/01 13:39:54 UTC

Re: Review Request 11861: double slash fix for windows based nfs servers [CLOUDSTACK-2968]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11861/
-----------------------------------------------------------

(Updated Aug. 1, 2013, 11:39 a.m.)


Review request for cloudstack and John Burwell.


Changes
-------

John, can you check if I need to rework or abandon this submission? thanks


Bugs: CLOUDSTACK-2968


Repository: cloudstack-git


Description
-------

double slash breaks windows based nfs servers [CLOUDSTACK-2968]


Diffs
-----

  api/src/com/cloud/storage/template/TemplateInfo.java 6559d73 
  core/src/com/cloud/agent/api/storage/CreateEntityDownloadURLCommand.java 98a957f 
  core/src/com/cloud/agent/api/storage/DownloadAnswer.java bb7b8a9 
  core/src/com/cloud/storage/template/TemplateLocation.java 58d023a 
  engine/schema/src/com/cloud/storage/VMTemplateHostVO.java b8dfc41 
  engine/storage/src/org/apache/cloudstack/storage/motion/AncientDataMotionStrategy.java a6880c3 
  server/src/com/cloud/storage/download/DownloadListener.java 1d48803 
  server/src/com/cloud/storage/download/DownloadMonitorImpl.java f72a563 
  server/src/com/cloud/template/HypervisorTemplateAdapter.java 322f32e 
  server/src/com/cloud/template/TemplateManagerImpl.java 517d4ba 
  utils/src/com/cloud/utils/FileUtil.java 74f4088 
  utils/test/com/cloud/utils/FileUtilTest.java PRE-CREATION 

Diff: https://reviews.apache.org/r/11861/diff/


Testing
-------

database analysis


Thanks,

daan Hoogland


Re: Review Request 11861: double slash fix for windows based nfs servers [CLOUDSTACK-2968]

Posted by Amogh Vasekar <am...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11861/#review28410
-----------------------------------------------------------


Reminder-
Hi,
The review has been pending for long. Please update the request if this patch is still necessary or is to be discarded.
Thanks

- Amogh Vasekar


On Aug. 1, 2013, 11:39 a.m., daan Hoogland wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11861/
> -----------------------------------------------------------
> 
> (Updated Aug. 1, 2013, 11:39 a.m.)
> 
> 
> Review request for cloudstack and John Burwell.
> 
> 
> Bugs: CLOUDSTACK-2968
>     https://issues.apache.org/jira/browse/CLOUDSTACK-2968
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> double slash breaks windows based nfs servers [CLOUDSTACK-2968]
> 
> 
> Diffs
> -----
> 
>   api/src/com/cloud/storage/template/TemplateInfo.java 6559d73 
>   core/src/com/cloud/agent/api/storage/CreateEntityDownloadURLCommand.java 98a957f 
>   core/src/com/cloud/agent/api/storage/DownloadAnswer.java bb7b8a9 
>   core/src/com/cloud/storage/template/TemplateLocation.java 58d023a 
>   engine/schema/src/com/cloud/storage/VMTemplateHostVO.java b8dfc41 
>   engine/storage/src/org/apache/cloudstack/storage/motion/AncientDataMotionStrategy.java a6880c3 
>   server/src/com/cloud/storage/download/DownloadListener.java 1d48803 
>   server/src/com/cloud/storage/download/DownloadMonitorImpl.java f72a563 
>   server/src/com/cloud/template/HypervisorTemplateAdapter.java 322f32e 
>   server/src/com/cloud/template/TemplateManagerImpl.java 517d4ba 
>   utils/src/com/cloud/utils/FileUtil.java 74f4088 
>   utils/test/com/cloud/utils/FileUtilTest.java PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/11861/diff/
> 
> 
> Testing
> -------
> 
> database analysis
> 
> 
> Thanks,
> 
> daan Hoogland
> 
>


Re: Review Request 11861: double slash fix for windows based nfs servers [CLOUDSTACK-2968]

Posted by "Jenkins Cloudstack.org" <hu...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11861/#review24436
-----------------------------------------------------------


Review 11861 failed the build test : FAILURE
The url of build cloudstack-master-with-patch #101 is : http://jenkins.cloudstack.org/job/cloudstack-master-with-patch/101/

- Jenkins Cloudstack.org


On Aug. 1, 2013, 11:39 a.m., daan Hoogland wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11861/
> -----------------------------------------------------------
> 
> (Updated Aug. 1, 2013, 11:39 a.m.)
> 
> 
> Review request for cloudstack and John Burwell.
> 
> 
> Bugs: CLOUDSTACK-2968
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> double slash breaks windows based nfs servers [CLOUDSTACK-2968]
> 
> 
> Diffs
> -----
> 
>   api/src/com/cloud/storage/template/TemplateInfo.java 6559d73 
>   core/src/com/cloud/agent/api/storage/CreateEntityDownloadURLCommand.java 98a957f 
>   core/src/com/cloud/agent/api/storage/DownloadAnswer.java bb7b8a9 
>   core/src/com/cloud/storage/template/TemplateLocation.java 58d023a 
>   engine/schema/src/com/cloud/storage/VMTemplateHostVO.java b8dfc41 
>   engine/storage/src/org/apache/cloudstack/storage/motion/AncientDataMotionStrategy.java a6880c3 
>   server/src/com/cloud/storage/download/DownloadListener.java 1d48803 
>   server/src/com/cloud/storage/download/DownloadMonitorImpl.java f72a563 
>   server/src/com/cloud/template/HypervisorTemplateAdapter.java 322f32e 
>   server/src/com/cloud/template/TemplateManagerImpl.java 517d4ba 
>   utils/src/com/cloud/utils/FileUtil.java 74f4088 
>   utils/test/com/cloud/utils/FileUtilTest.java PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/11861/diff/
> 
> 
> Testing
> -------
> 
> database analysis
> 
> 
> Thanks,
> 
> daan Hoogland
> 
>