You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by James Peach <jp...@apache.org> on 2017/04/10 15:50:04 UTC
Review Request 58305: Add some parameter validation to
ReRegisterSlaveMessage.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58305/
-----------------------------------------------------------
Review request for mesos and Mesos Reviewbot.
Bugs: MESOS-7372.
https://issues.apache.org/jira/browse/MESOS-7372.
Repository: mesos
Description
-------
The ReRegisterSlaveMessage message sends a number of fields which have
internal consistency requirements. Add some simple validation checks
to ensure that we have a minimally consistent re-registration request
before proceeding.
Diffs
-----
src/master/master.cpp c1f3c4f3bbcbfb10ae8fc974bd4a16ec070a79fd
src/master/validation.hpp d96287de73ddb30ae2ed841c1b910b0ac6cfa74e
src/master/validation.cpp 3f70875484bbd856ac79a7d6070ac313d69782fa
Diff: https://reviews.apache.org/r/58305/diff/1/
Testing
-------
Make check (Fedora 25). Internal fuzzing.
Thanks,
James Peach
Re: Review Request 58305: Add some parameter validation to
ReRegisterSlaveMessage.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58305/#review171449
-----------------------------------------------------------
Patch looks great!
Reviews applied: [58303, 58304, 58305]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On April 10, 2017, 3:50 p.m., James Peach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58305/
> -----------------------------------------------------------
>
> (Updated April 10, 2017, 3:50 p.m.)
>
>
> Review request for mesos and Mesos Reviewbot.
>
>
> Bugs: MESOS-7372.
> https://issues.apache.org/jira/browse/MESOS-7372.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The ReRegisterSlaveMessage message sends a number of fields which have
> internal consistency requirements. Add some simple validation checks
> to ensure that we have a minimally consistent re-registration request
> before proceeding.
>
>
> Diffs
> -----
>
> src/master/master.cpp c1f3c4f3bbcbfb10ae8fc974bd4a16ec070a79fd
> src/master/validation.hpp d96287de73ddb30ae2ed841c1b910b0ac6cfa74e
> src/master/validation.cpp 3f70875484bbd856ac79a7d6070ac313d69782fa
>
>
> Diff: https://reviews.apache.org/r/58305/diff/1/
>
>
> Testing
> -------
>
> Make check (Fedora 25). Internal fuzzing.
>
>
> Thanks,
>
> James Peach
>
>
Re: Review Request 58305: Add some parameter validation to
ReRegisterSlaveMessage.
Posted by James Peach <jp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58305/
-----------------------------------------------------------
(Updated April 11, 2017, 4:28 p.m.)
Review request for mesos and Mesos Reviewbot.
Changes
-------
Rebased.
Bugs: MESOS-7372.
https://issues.apache.org/jira/browse/MESOS-7372.
Repository: mesos
Description
-------
The ReRegisterSlaveMessage message sends a number of fields which have
internal consistency requirements. Add some simple validation checks
to ensure that we have a minimally consistent re-registration request
before proceeding.
Diffs (updated)
-----
src/master/master.cpp c1f3c4f3bbcbfb10ae8fc974bd4a16ec070a79fd
src/master/validation.hpp d96287de73ddb30ae2ed841c1b910b0ac6cfa74e
src/master/validation.cpp 3f70875484bbd856ac79a7d6070ac313d69782fa
Diff: https://reviews.apache.org/r/58305/diff/2/
Changes: https://reviews.apache.org/r/58305/diff/1-2/
Testing
-------
Make check (Fedora 25). Internal fuzzing.
Thanks,
James Peach