[GitHub] [knox] moresandeep commented on a change in pull request #264: KNOX-2233 - DefaultKeystoreService getCredentialForCluster uses cache…

[GitBox <gi...@apache.org>]

moresandeep commented on a change in pull request #264: KNOX-2233 - DefaultKeystoreService getCredentialForCluster uses cache…
URL: https://github.com/apache/knox/pull/264#discussion_r378491444
 
 

 ##########
 File path: gateway-server/src/main/java/org/apache/knox/gateway/services/security/impl/DefaultKeystoreService.java
 ##########
 @@ -309,25 +309,30 @@ public void addCredentialForCluster(String clusterName, String alias, String val
   @Override
   public char[] getCredentialForCluster(String clusterName, String alias)
       throws KeystoreServiceException {
-    char[] credential = checkCache(clusterName, alias);
-    if (credential == null) {
-      KeyStore ks = getCredentialStoreForCluster(clusterName);
-      if (ks != null) {
-        try {
-          char[] masterSecret = masterService.getMasterSecret();
-          Key credentialKey = ks.getKey( alias, masterSecret );
-          if (credentialKey != null) {
-            byte[] credentialBytes = credentialKey.getEncoded();
-            String credentialString = new String( credentialBytes, StandardCharsets.UTF_8 );
-            credential = credentialString.toCharArray();
-            addToCache(clusterName, alias, credentialString);
+    char[] credential;
+
+    synchronized (this) {
 
 Review comment:
   Instead of synchronizing the whole block wouldn't it be better to add something like a ReadWriteLock ? 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services