You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2019/07/03 08:53:07 UTC

[GitHub] [rocketmq-client-go] xujianhai666 opened a new issue #88: use golangci to improve code quality

xujianhai666 opened a new issue #88: use golangci to improve code quality 
URL: https://github.com/apache/rocketmq-client-go/issues/88
 
 
   **FEATURE REQUEST**
   
   1. Please describe the feature you are requesting.
   I found that the code in native is so terrible to maintain, maybe author of client is not deeply familar with golang, so in order to improve code quality and pr quality, I think it is time to introduce golangci tool. more info about golangci: https://github.com/golangci/golangci-lint
   
   
   2. Provide any additional detail on your proposed use case for this feature.
   
   - avoid race case
   - useless code
   - more concise impl
   - field arrangement in struct for less byte
   
   2. Indicate the importance of this issue to you (blocker, must-have, should-have, nice-to-have).  
    nice-to-have
   
   
   4. If there are some sub-tasks using -[] for each subtask and create a corresponding issue to map to the sub task:
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services