You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/12/15 22:59:08 UTC

[GitHub] [incubator-superset] mihir174 commented on pull request #12008: feat(explore-datasource): add new datasource tab to explore view

mihir174 commented on pull request #12008:
URL: https://github.com/apache/incubator-superset/pull/12008#issuecomment-745619798


   "5. uneven padding around datasource and "..." icon (@mihir174, your call)
   6. Columns and Metrics should be bold, according to the design
   7. Spacing between is too large"
   
   Agree with all of these, I've attached the spacing guidelines that I sent to Evan and Philip. I don't think any of these are critical issues for the time being, so they can be added in the next PR
   ![Uploading Screen Shot 2020-12-14 at 2.53.45 PM.png…]()
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org