You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/09/01 09:12:22 UTC
[GitHub] [apisix-ingress-controller] SergeBakharev opened a new pull request #657: docs: correct helm repo
SergeBakharev opened a new pull request #657:
URL: https://github.com/apache/apisix-ingress-controller/pull/657
Please answer these questions before submitting a pull request
- Why submit this pull request?
- [ x ] Bugfix
- [ ] New feature provided
- [ ] Improve performance
- [ ] Backport patches
- Related issues
___
### Bugfix
- Description
Documentation for helm chart repo was out of date
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] tokers commented on a change in pull request #657: docs: correct helm repo
Posted by GitBox <gi...@apache.org>.
tokers commented on a change in pull request #657:
URL: https://github.com/apache/apisix-ingress-controller/pull/657#discussion_r699779480
##########
File path: docs/en/latest/deployments/ack.md
##########
@@ -36,11 +36,10 @@ This document explains how to install Ingress APISIX on [ali-cloud ACK](https://
As the data plane of apisix-ingress-controller, [Apache APISIX](http://apisix.apache.org/) can be deployed at the same time using Helm chart.
```shell
-cd /path/to/apisix-helm-chart
-helm repo add bitnami https://charts.bitnami.com/bitnami
Review comment:
We recommend people to use the online repo, so I think `helm repo add apisix https://charts.apiseven.com` is OK.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 commented on pull request #657: docs: correct helm repo
Posted by GitBox <gi...@apache.org>.
tao12345666333 commented on pull request #657:
URL: https://github.com/apache/apisix-ingress-controller/pull/657#issuecomment-930803233
We plan to enter the code freeze period and release the v1.3 version. If possible, I hope to include this change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] gxthrj merged pull request #657: docs: correct helm repo
Posted by GitBox <gi...@apache.org>.
gxthrj merged pull request #657:
URL: https://github.com/apache/apisix-ingress-controller/pull/657
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 commented on a change in pull request #657: docs: correct helm repo
Posted by GitBox <gi...@apache.org>.
tao12345666333 commented on a change in pull request #657:
URL: https://github.com/apache/apisix-ingress-controller/pull/657#discussion_r699133906
##########
File path: docs/en/latest/deployments/ack.md
##########
@@ -36,11 +36,10 @@ This document explains how to install Ingress APISIX on [ali-cloud ACK](https://
As the data plane of apisix-ingress-controller, [Apache APISIX](http://apisix.apache.org/) can be deployed at the same time using Helm chart.
```shell
-cd /path/to/apisix-helm-chart
-helm repo add bitnami https://charts.bitnami.com/bitnami
Review comment:
We shouldn't remove this line. APISIX needs bitnami/etcd
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] gxthrj commented on pull request #657: docs: correct helm repo
Posted by GitBox <gi...@apache.org>.
gxthrj commented on pull request #657:
URL: https://github.com/apache/apisix-ingress-controller/pull/657#issuecomment-909933096
Please add a choice about using helm repo to install `apisix ingress `.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] SergeBakharev commented on a change in pull request #657: docs: correct helm repo
Posted by GitBox <gi...@apache.org>.
SergeBakharev commented on a change in pull request #657:
URL: https://github.com/apache/apisix-ingress-controller/pull/657#discussion_r699713916
##########
File path: docs/en/latest/deployments/ack.md
##########
@@ -36,11 +36,10 @@ This document explains how to install Ingress APISIX on [ali-cloud ACK](https://
As the data plane of apisix-ingress-controller, [Apache APISIX](http://apisix.apache.org/) can be deployed at the same time using Helm chart.
```shell
-cd /path/to/apisix-helm-chart
-helm repo add bitnami https://charts.bitnami.com/bitnami
Review comment:
Ah I now understand, the `cd /path/to/apisix-helm-chart` step is because we are expecting the user to have a local copy of the chart, thus the `helm install apisix charts/apisix` is referring to a relative path on the local file system not a repo. This was not immediately obvious because the chart is not present in this repo.
I think it would be best if the install documentation used a helm repo, but I see you are considering moving hosting to github.
Can I suggest an explicit step to clone the helm chart from github until the repo hosting is resolved?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] tokers commented on a change in pull request #657: docs: correct helm repo
Posted by GitBox <gi...@apache.org>.
tokers commented on a change in pull request #657:
URL: https://github.com/apache/apisix-ingress-controller/pull/657#discussion_r699779480
##########
File path: docs/en/latest/deployments/ack.md
##########
@@ -36,11 +36,10 @@ This document explains how to install Ingress APISIX on [ali-cloud ACK](https://
As the data plane of apisix-ingress-controller, [Apache APISIX](http://apisix.apache.org/) can be deployed at the same time using Helm chart.
```shell
-cd /path/to/apisix-helm-chart
-helm repo add bitnami https://charts.bitnami.com/bitnami
Review comment:
We recommend people to use the online repo, so I think `helm repo add apisix https://charts.apiseven.com` is OK.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] gxthrj merged pull request #657: docs: correct helm repo
Posted by GitBox <gi...@apache.org>.
gxthrj merged pull request #657:
URL: https://github.com/apache/apisix-ingress-controller/pull/657
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 commented on a change in pull request #657: docs: correct helm repo
Posted by GitBox <gi...@apache.org>.
tao12345666333 commented on a change in pull request #657:
URL: https://github.com/apache/apisix-ingress-controller/pull/657#discussion_r699133906
##########
File path: docs/en/latest/deployments/ack.md
##########
@@ -36,11 +36,10 @@ This document explains how to install Ingress APISIX on [ali-cloud ACK](https://
As the data plane of apisix-ingress-controller, [Apache APISIX](http://apisix.apache.org/) can be deployed at the same time using Helm chart.
```shell
-cd /path/to/apisix-helm-chart
-helm repo add bitnami https://charts.bitnami.com/bitnami
Review comment:
We shouldn't remove this line. APISIX needs bitnami/etcd
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] gxthrj commented on pull request #657: docs: correct helm repo
Posted by GitBox <gi...@apache.org>.
gxthrj commented on pull request #657:
URL: https://github.com/apache/apisix-ingress-controller/pull/657#issuecomment-909933096
Please add a choice about using helm repo to install `apisix ingress `.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 commented on pull request #657: docs: correct helm repo
Posted by GitBox <gi...@apache.org>.
tao12345666333 commented on pull request #657:
URL: https://github.com/apache/apisix-ingress-controller/pull/657#issuecomment-939246680
@SergeBakharev We plan to release the v1.3 version, and I will improve it on the basis of your PR to merge it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] SergeBakharev commented on a change in pull request #657: docs: correct helm repo
Posted by GitBox <gi...@apache.org>.
SergeBakharev commented on a change in pull request #657:
URL: https://github.com/apache/apisix-ingress-controller/pull/657#discussion_r699713916
##########
File path: docs/en/latest/deployments/ack.md
##########
@@ -36,11 +36,10 @@ This document explains how to install Ingress APISIX on [ali-cloud ACK](https://
As the data plane of apisix-ingress-controller, [Apache APISIX](http://apisix.apache.org/) can be deployed at the same time using Helm chart.
```shell
-cd /path/to/apisix-helm-chart
-helm repo add bitnami https://charts.bitnami.com/bitnami
Review comment:
Ah I now understand, the `cd /path/to/apisix-helm-chart` step is because we are expecting the user to have a local copy of the chart, thus the `helm install apisix charts/apisix` is referring to a relative path on the local file system not a repo. This was not immediately obvious because the chart is not present in this repo.
I think it would be best if the install documentation used a helm repo, but I see you are considering moving hosting to github.
Can I suggest an explicit step to clone the helm chart from github until the repo hosting is resolved?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 commented on a change in pull request #657: docs: correct helm repo
Posted by GitBox <gi...@apache.org>.
tao12345666333 commented on a change in pull request #657:
URL: https://github.com/apache/apisix-ingress-controller/pull/657#discussion_r699133906
##########
File path: docs/en/latest/deployments/ack.md
##########
@@ -36,11 +36,10 @@ This document explains how to install Ingress APISIX on [ali-cloud ACK](https://
As the data plane of apisix-ingress-controller, [Apache APISIX](http://apisix.apache.org/) can be deployed at the same time using Helm chart.
```shell
-cd /path/to/apisix-helm-chart
-helm repo add bitnami https://charts.bitnami.com/bitnami
Review comment:
We shouldn't remove this line. APISIX needs bitnami/etcd
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 commented on pull request #657: docs: correct helm repo
Posted by GitBox <gi...@apache.org>.
tao12345666333 commented on pull request #657:
URL: https://github.com/apache/apisix-ingress-controller/pull/657#issuecomment-930802780
Hello, do you have time to continue to adjust this PR? @SergeBakharev
I suggest to keep two ways
* Use chart published to Helm repo
* Use the source code repository of helm-chart
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] tokers commented on pull request #657: docs: correct helm repo
Posted by GitBox <gi...@apache.org>.
tokers commented on pull request #657:
URL: https://github.com/apache/apisix-ingress-controller/pull/657#issuecomment-912397828
> Happy to write some extra notes, but I don't understand myself. Why would someone install just the ingress-controller without APISIX? Is this something you would do to enable `helm upgrade` capability to target specifically the ingress-controller component without upgrading APISIX version as well?
Well, we can install apisix and apisix-ingress-controller within one `helm install` command, and unfortunately, we're not capable to control the start order of apisix-ingress-controller and apisix. So here we use the `initContainer` to detect the apisix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] SergeBakharev commented on pull request #657: docs: correct helm repo
Posted by GitBox <gi...@apache.org>.
SergeBakharev commented on pull request #657:
URL: https://github.com/apache/apisix-ingress-controller/pull/657#issuecomment-912318105
Happy to write some extra notes, but I don't understand myself. Why would someone install just the ingress-controller without APISIX? Is this something you would do to enable `helm upgrade` capability to target specifically the ingress-controller component without upgrading APISIX version as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org