You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/02/08 21:18:53 UTC

[GitHub] [pulsar] merlimat opened a new pull request #9533: [C++] Removed usages of boost::regex

merlimat opened a new pull request #9533:
URL: https://github.com/apache/pulsar/pull/9533


   ### Motivation
   
   Remove boost::regex which is the only remaining runtime boost dependency.
   
   ### Changes
   
   Removed the usage of `boost::regex`, substituting with `std::regex`. We only need to use boost::regex with old gcc versions that have buggy implementation of regexes. In particular, this happens with G++ 4.8.2  which is the one used when building `manylinux1` Python wheel files.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] gaoran10 commented on pull request #9533: [C++] Removed usages of boost::regex

Posted by GitBox <gi...@apache.org>.
gaoran10 commented on pull request #9533:
URL: https://github.com/apache/pulsar/pull/9533#issuecomment-776058750


   /pulsarbot run-failure-checks


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] jiazhai commented on pull request #9533: [C++] Removed usages of boost::regex

Posted by GitBox <gi...@apache.org>.
jiazhai commented on pull request #9533:
URL: https://github.com/apache/pulsar/pull/9533#issuecomment-775597246


   @BewareMyPower Would you please also help review this PR?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] merlimat merged pull request #9533: [C++] Removed usages of boost::regex

Posted by GitBox <gi...@apache.org>.
merlimat merged pull request #9533:
URL: https://github.com/apache/pulsar/pull/9533


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org