You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sentry.apache.org by Colm O hEigeartaigh <co...@apache.org> on 2017/10/16 11:33:51 UTC
Review Request 63026: SENTRY-1979 - Consolidate code for converting
Hive privilege objects to Strings
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63026/
-----------------------------------------------------------
Review request for sentry.
Bugs: SENTRY-1979
https://issues.apache.org/jira/browse/SENTRY-1979
Repository: sentry
Description
-------
This task is to consolidate the code for converting Hive privileges objects to Strings. We have some duplicate code that is used by the shell that could be removed.
Diffs
-----
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/tools/command/hive/CommandUtil.java 51ee9efc
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/tools/command/hive/GrantPrivilegeToRoleCmd.java e3d06a97
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/tools/command/hive/ListPrivilegesCmd.java 5f3e9fbc
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/tools/command/hive/RevokePrivilegeFromRoleCmd.java fe6aca5d
sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/tools/TestSentryShellHive.java 81059c5f
Diff: https://reviews.apache.org/r/63026/diff/1/
Testing
-------
Tested the Hive Shell.
Thanks,
Colm O hEigeartaigh
Re: Review Request 63026: SENTRY-1979 - Consolidate code for
converting Hive privilege objects to Strings
Posted by Na Li via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63026/#review188202
-----------------------------------------------------------
Ship it!
Ship It!
- Na Li
On Oct. 16, 2017, 11:33 a.m., Colm O hEigeartaigh wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63026/
> -----------------------------------------------------------
>
> (Updated Oct. 16, 2017, 11:33 a.m.)
>
>
> Review request for sentry.
>
>
> Bugs: SENTRY-1979
> https://issues.apache.org/jira/browse/SENTRY-1979
>
>
> Repository: sentry
>
>
> Description
> -------
>
> This task is to consolidate the code for converting Hive privileges objects to Strings. We have some duplicate code that is used by the shell that could be removed.
>
>
> Diffs
> -----
>
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/tools/command/hive/CommandUtil.java 51ee9efc
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/tools/command/hive/GrantPrivilegeToRoleCmd.java e3d06a97
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/tools/command/hive/ListPrivilegesCmd.java 5f3e9fbc
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/tools/command/hive/RevokePrivilegeFromRoleCmd.java fe6aca5d
> sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/tools/TestSentryShellHive.java 81059c5f
>
>
> Diff: https://reviews.apache.org/r/63026/diff/1/
>
>
> Testing
> -------
>
> Tested the Hive Shell.
>
>
> Thanks,
>
> Colm O hEigeartaigh
>
>
Re: Review Request 63026: SENTRY-1979 - Consolidate code for
converting Hive privilege objects to Strings
Posted by Alexander Kolbasov <ak...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63026/#review188187
-----------------------------------------------------------
Ship it!
Ship It!
- Alexander Kolbasov
On Oct. 16, 2017, 11:33 a.m., Colm O hEigeartaigh wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63026/
> -----------------------------------------------------------
>
> (Updated Oct. 16, 2017, 11:33 a.m.)
>
>
> Review request for sentry.
>
>
> Bugs: SENTRY-1979
> https://issues.apache.org/jira/browse/SENTRY-1979
>
>
> Repository: sentry
>
>
> Description
> -------
>
> This task is to consolidate the code for converting Hive privileges objects to Strings. We have some duplicate code that is used by the shell that could be removed.
>
>
> Diffs
> -----
>
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/tools/command/hive/CommandUtil.java 51ee9efc
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/tools/command/hive/GrantPrivilegeToRoleCmd.java e3d06a97
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/tools/command/hive/ListPrivilegesCmd.java 5f3e9fbc
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/tools/command/hive/RevokePrivilegeFromRoleCmd.java fe6aca5d
> sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/tools/TestSentryShellHive.java 81059c5f
>
>
> Diff: https://reviews.apache.org/r/63026/diff/1/
>
>
> Testing
> -------
>
> Tested the Hive Shell.
>
>
> Thanks,
>
> Colm O hEigeartaigh
>
>
Re: Review Request 63026: SENTRY-1979 - Consolidate code for
converting Hive privilege objects to Strings
Posted by Sergio Pena via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63026/#review188184
-----------------------------------------------------------
Ship it!
Patch looks good.
- Sergio Pena
On Oct. 16, 2017, 11:33 a.m., Colm O hEigeartaigh wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63026/
> -----------------------------------------------------------
>
> (Updated Oct. 16, 2017, 11:33 a.m.)
>
>
> Review request for sentry.
>
>
> Bugs: SENTRY-1979
> https://issues.apache.org/jira/browse/SENTRY-1979
>
>
> Repository: sentry
>
>
> Description
> -------
>
> This task is to consolidate the code for converting Hive privileges objects to Strings. We have some duplicate code that is used by the shell that could be removed.
>
>
> Diffs
> -----
>
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/tools/command/hive/CommandUtil.java 51ee9efc
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/tools/command/hive/GrantPrivilegeToRoleCmd.java e3d06a97
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/tools/command/hive/ListPrivilegesCmd.java 5f3e9fbc
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/tools/command/hive/RevokePrivilegeFromRoleCmd.java fe6aca5d
> sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/tools/TestSentryShellHive.java 81059c5f
>
>
> Diff: https://reviews.apache.org/r/63026/diff/1/
>
>
> Testing
> -------
>
> Tested the Hive Shell.
>
>
> Thanks,
>
> Colm O hEigeartaigh
>
>