You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2020/11/04 23:37:53 UTC

[GitHub] [trafficcontrol] zrhoffman edited a comment on pull request #5229: apache/trafficcontrol is a Go module

zrhoffman edited a comment on pull request #5229:
URL: https://github.com/apache/trafficcontrol/pull/5229#issuecomment-720155304


   > Why'd you rewrite the go-test action for this? And why does its package.json require typescript if you're not using it?
   
   `go mod` resolves symlinks, which is a problem since our `go-test` action symlinks the workspace into the `GOPATH`. We can keep the Docker action, but that means cloning the project into `src/github.com/apache/trafficcontrol` in the workspace, instead of the workspace directory being the repo directory.
   
   Reverted making `go-test` a JavaScript action in 679bf31754, checking out the project in the GOPATH in ddafc65fba.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org