You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Bikas Saha (JIRA)" <ji...@apache.org> on 2012/09/26 02:54:07 UTC
[jira] [Created] (HADOOP-8847) Change untar to use Java API instead
of spawning tar process
Bikas Saha created HADOOP-8847:
----------------------------------
Summary: Change untar to use Java API instead of spawning tar process
Key: HADOOP-8847
URL: https://issues.apache.org/jira/browse/HADOOP-8847
Project: Hadoop Common
Issue Type: Improvement
Reporter: Bikas Saha
Assignee: Bikas Saha
Currently FileUtil.unTar() spawns tar utility to do the work. Tar may not be present on all platforms by default eg. Windows. So changing this to use JAVA API's would help make it more cross-platform. FileUtil.unZip() uses the same approach.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-8847) Change untar to use Java API on
Windows instead of spawning tar process
Posted by "Suresh Srinivas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8847?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Suresh Srinivas updated HADOOP-8847:
------------------------------------
Summary: Change untar to use Java API on Windows instead of spawning tar process (was: Change untar to use Java API instead of spawning tar process)
> Change untar to use Java API on Windows instead of spawning tar process
> -----------------------------------------------------------------------
>
> Key: HADOOP-8847
> URL: https://issues.apache.org/jira/browse/HADOOP-8847
> Project: Hadoop Common
> Issue Type: Improvement
> Affects Versions: 1-win
> Reporter: Bikas Saha
> Assignee: Bikas Saha
> Attachments: HADOOP-8847.branch-1-win.1.patch, HADOOP-8847.branch-1-win.2.patch, HADOOP-8847.branch-1-win.3.patch, HADOOP-8847.branch-1-win.4.patch, test-untar.tar, test-untar.tgz
>
>
> Currently FileUtil.unTar() spawns tar utility to do the work. Tar may not be present on all platforms by default eg. Windows. So changing this to use JAVA API's would help make it more cross-platform. FileUtil.unZip() uses the same approach.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8847) Change untar to use Java API
instead of spawning tar process
Posted by "Steve Loughran (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13463978#comment-13463978 ]
Steve Loughran commented on HADOOP-8847:
----------------------------------------
@Robert, I know Ant's {{<untar>}} task doesn't handle perms; a look at the apache compress library shows that {{TarEntry.getMode()}} does return them -the untarring logic may be able to convert them into FS state operations, using {{File.setExecutable()}} and {{File.setWritable()}}. This needs to be done in the untarring process itself.
tar perms are only going to matter in Unix-land, so perhaps the strategy here is to make the java untar the default on windows, but not the default on other platforms.
> Change untar to use Java API instead of spawning tar process
> ------------------------------------------------------------
>
> Key: HADOOP-8847
> URL: https://issues.apache.org/jira/browse/HADOOP-8847
> Project: Hadoop Common
> Issue Type: Improvement
> Reporter: Bikas Saha
> Assignee: Bikas Saha
> Attachments: HADOOP-8847.branch-1-win.1.patch, test-untar.tar, test-untar.tgz
>
>
> Currently FileUtil.unTar() spawns tar utility to do the work. Tar may not be present on all platforms by default eg. Windows. So changing this to use JAVA API's would help make it more cross-platform. FileUtil.unZip() uses the same approach.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8847) Change untar to use Java API
instead of spawning tar process
Posted by "Joep Rottinghuis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13468721#comment-13468721 ]
Joep Rottinghuis commented on HADOOP-8847:
------------------------------------------
Are symlinks a factor in the pure Java implementation?
On Unix, tar will handle symlinks appropriately and restore them properly (even if there are loops in the symlinks). Recursive descent with loops could be a problem.
As long as Java implementation is limited to Windows this may not matter.
> Change untar to use Java API instead of spawning tar process
> ------------------------------------------------------------
>
> Key: HADOOP-8847
> URL: https://issues.apache.org/jira/browse/HADOOP-8847
> Project: Hadoop Common
> Issue Type: Improvement
> Reporter: Bikas Saha
> Assignee: Bikas Saha
> Attachments: HADOOP-8847.branch-1-win.1.patch, test-untar.tar, test-untar.tgz
>
>
> Currently FileUtil.unTar() spawns tar utility to do the work. Tar may not be present on all platforms by default eg. Windows. So changing this to use JAVA API's would help make it more cross-platform. FileUtil.unZip() uses the same approach.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8847) Change untar to use Java API
instead of spawning tar process
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13463513#comment-13463513 ]
Hadoop QA commented on HADOOP-8847:
-----------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12546629/HADOOP-8847.branch-1-win.1.patch
against trunk revision .
{color:red}-1 patch{color}. The patch command could not apply the patch.
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/1523//console
This message is automatically generated.
> Change untar to use Java API instead of spawning tar process
> ------------------------------------------------------------
>
> Key: HADOOP-8847
> URL: https://issues.apache.org/jira/browse/HADOOP-8847
> Project: Hadoop Common
> Issue Type: Improvement
> Reporter: Bikas Saha
> Assignee: Bikas Saha
> Attachments: HADOOP-8847.branch-1-win.1.patch, test-untar.tar, test-untar.tgz
>
>
> Currently FileUtil.unTar() spawns tar utility to do the work. Tar may not be present on all platforms by default eg. Windows. So changing this to use JAVA API's would help make it more cross-platform. FileUtil.unZip() uses the same approach.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8847) Change untar to use Java API
instead of spawning tar process
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13471165#comment-13471165 ]
Hadoop QA commented on HADOOP-8847:
-----------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12548151/HADOOP-8847.branch-1-win.2.patch
against trunk revision .
{color:red}-1 patch{color}. The patch command could not apply the patch.
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/1573//console
This message is automatically generated.
> Change untar to use Java API instead of spawning tar process
> ------------------------------------------------------------
>
> Key: HADOOP-8847
> URL: https://issues.apache.org/jira/browse/HADOOP-8847
> Project: Hadoop Common
> Issue Type: Improvement
> Reporter: Bikas Saha
> Assignee: Bikas Saha
> Attachments: HADOOP-8847.branch-1-win.1.patch, HADOOP-8847.branch-1-win.2.patch, test-untar.tar, test-untar.tgz
>
>
> Currently FileUtil.unTar() spawns tar utility to do the work. Tar may not be present on all platforms by default eg. Windows. So changing this to use JAVA API's would help make it more cross-platform. FileUtil.unZip() uses the same approach.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8847) Change untar to use Java API
instead of spawning tar process
Posted by "Steve Loughran (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13463639#comment-13463639 ]
Steve Loughran commented on HADOOP-8847:
----------------------------------------
correction -you aren't using any Sun Java APIs -I misread that. Commons compress 1.1+ claims to handle Posix [ https://issues.apache.org/jira/browse/COMPRESS-110 ]; Ant's handled LFNs for a long time.
All that is needed is tests to verify that LFNs are handled.
Ignoring file permissions may be backwards incompatible, but I'm not sure if anyone was actually using it. It's probably best to tag it as such just to avoid surprises.
-steve
> Change untar to use Java API instead of spawning tar process
> ------------------------------------------------------------
>
> Key: HADOOP-8847
> URL: https://issues.apache.org/jira/browse/HADOOP-8847
> Project: Hadoop Common
> Issue Type: Improvement
> Reporter: Bikas Saha
> Assignee: Bikas Saha
> Attachments: HADOOP-8847.branch-1-win.1.patch, test-untar.tar, test-untar.tgz
>
>
> Currently FileUtil.unTar() spawns tar utility to do the work. Tar may not be present on all platforms by default eg. Windows. So changing this to use JAVA API's would help make it more cross-platform. FileUtil.unZip() uses the same approach.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-8847) Change untar to use Java API instead
of spawning tar process
Posted by "Bikas Saha (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8847?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bikas Saha updated HADOOP-8847:
-------------------------------
Status: Patch Available (was: Open)
> Change untar to use Java API instead of spawning tar process
> ------------------------------------------------------------
>
> Key: HADOOP-8847
> URL: https://issues.apache.org/jira/browse/HADOOP-8847
> Project: Hadoop Common
> Issue Type: Improvement
> Reporter: Bikas Saha
> Assignee: Bikas Saha
> Attachments: HADOOP-8847.branch-1-win.1.patch, HADOOP-8847.branch-1-win.2.patch, HADOOP-8847.branch-1-win.3.patch, test-untar.tar, test-untar.tgz
>
>
> Currently FileUtil.unTar() spawns tar utility to do the work. Tar may not be present on all platforms by default eg. Windows. So changing this to use JAVA API's would help make it more cross-platform. FileUtil.unZip() uses the same approach.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8847) Change untar to use Java API
instead of spawning tar process
Posted by "Steve Loughran (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13475389#comment-13475389 ]
Steve Loughran commented on HADOOP-8847:
----------------------------------------
Bikas -is there any reason to not make the {{close()}} operation in {{unpackEntries()}} part of the try/finally logic? Other than that it looks good to be -the {{Shell.WINDOWS}} checks ensure that the Unix untars will be the existing shell commands and not break anything
> Change untar to use Java API instead of spawning tar process
> ------------------------------------------------------------
>
> Key: HADOOP-8847
> URL: https://issues.apache.org/jira/browse/HADOOP-8847
> Project: Hadoop Common
> Issue Type: Improvement
> Reporter: Bikas Saha
> Assignee: Bikas Saha
> Attachments: HADOOP-8847.branch-1-win.1.patch, HADOOP-8847.branch-1-win.2.patch, test-untar.tar, test-untar.tgz
>
>
> Currently FileUtil.unTar() spawns tar utility to do the work. Tar may not be present on all platforms by default eg. Windows. So changing this to use JAVA API's would help make it more cross-platform. FileUtil.unZip() uses the same approach.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8847) Change untar to use Java API
instead of spawning tar process
Posted by "Bikas Saha (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13475267#comment-13475267 ]
Bikas Saha commented on HADOOP-8847:
------------------------------------
Is there anything else left for me to do wrt getting this patch ready for commit?
> Change untar to use Java API instead of spawning tar process
> ------------------------------------------------------------
>
> Key: HADOOP-8847
> URL: https://issues.apache.org/jira/browse/HADOOP-8847
> Project: Hadoop Common
> Issue Type: Improvement
> Reporter: Bikas Saha
> Assignee: Bikas Saha
> Attachments: HADOOP-8847.branch-1-win.1.patch, HADOOP-8847.branch-1-win.2.patch, test-untar.tar, test-untar.tgz
>
>
> Currently FileUtil.unTar() spawns tar utility to do the work. Tar may not be present on all platforms by default eg. Windows. So changing this to use JAVA API's would help make it more cross-platform. FileUtil.unZip() uses the same approach.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-8847) Change untar to use Java API instead
of spawning tar process
Posted by "Bikas Saha (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8847?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bikas Saha updated HADOOP-8847:
-------------------------------
Attachment: HADOOP-8847.branch-1-win.3.patch
Rebasing patch
> Change untar to use Java API instead of spawning tar process
> ------------------------------------------------------------
>
> Key: HADOOP-8847
> URL: https://issues.apache.org/jira/browse/HADOOP-8847
> Project: Hadoop Common
> Issue Type: Improvement
> Reporter: Bikas Saha
> Assignee: Bikas Saha
> Attachments: HADOOP-8847.branch-1-win.1.patch, HADOOP-8847.branch-1-win.2.patch, HADOOP-8847.branch-1-win.3.patch, test-untar.tar, test-untar.tgz
>
>
> Currently FileUtil.unTar() spawns tar utility to do the work. Tar may not be present on all platforms by default eg. Windows. So changing this to use JAVA API's would help make it more cross-platform. FileUtil.unZip() uses the same approach.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8847) Change untar to use Java API
instead of spawning tar process
Posted by "Bikas Saha (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13463957#comment-13463957 ]
Bikas Saha commented on HADOOP-8847:
------------------------------------
I will try to add a long file name into the tar file and check that.
>From what I have seen, callers who need specific permissions have to set them after unTar because tar does not do it for them. I see the code in distributed shell explicitly set permissions after the untar operation.
> Change untar to use Java API instead of spawning tar process
> ------------------------------------------------------------
>
> Key: HADOOP-8847
> URL: https://issues.apache.org/jira/browse/HADOOP-8847
> Project: Hadoop Common
> Issue Type: Improvement
> Reporter: Bikas Saha
> Assignee: Bikas Saha
> Attachments: HADOOP-8847.branch-1-win.1.patch, test-untar.tar, test-untar.tgz
>
>
> Currently FileUtil.unTar() spawns tar utility to do the work. Tar may not be present on all platforms by default eg. Windows. So changing this to use JAVA API's would help make it more cross-platform. FileUtil.unZip() uses the same approach.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8847) Change untar to use Java API
instead of spawning tar process
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13486749#comment-13486749 ]
Hadoop QA commented on HADOOP-8847:
-----------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12551327/HADOOP-8847.branch-1-win.3.patch
against trunk revision .
{color:red}-1 patch{color}. The patch command could not apply the patch.
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/1689//console
This message is automatically generated.
> Change untar to use Java API instead of spawning tar process
> ------------------------------------------------------------
>
> Key: HADOOP-8847
> URL: https://issues.apache.org/jira/browse/HADOOP-8847
> Project: Hadoop Common
> Issue Type: Improvement
> Reporter: Bikas Saha
> Assignee: Bikas Saha
> Attachments: HADOOP-8847.branch-1-win.1.patch, HADOOP-8847.branch-1-win.2.patch, HADOOP-8847.branch-1-win.3.patch, test-untar.tar, test-untar.tgz
>
>
> Currently FileUtil.unTar() spawns tar utility to do the work. Tar may not be present on all platforms by default eg. Windows. So changing this to use JAVA API's would help make it more cross-platform. FileUtil.unZip() uses the same approach.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-8847) Change untar to use Java API on
Windows instead of spawning tar process
Posted by "Suresh Srinivas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8847?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Suresh Srinivas updated HADOOP-8847:
------------------------------------
Resolution: Fixed
Fix Version/s: 1-win
Hadoop Flags: Reviewed
Status: Resolved (was: Patch Available)
Committed the patch to branch-1-win. Thank you Bikas!
> Change untar to use Java API on Windows instead of spawning tar process
> -----------------------------------------------------------------------
>
> Key: HADOOP-8847
> URL: https://issues.apache.org/jira/browse/HADOOP-8847
> Project: Hadoop Common
> Issue Type: Improvement
> Affects Versions: 1-win
> Reporter: Bikas Saha
> Assignee: Bikas Saha
> Fix For: 1-win
>
> Attachments: HADOOP-8847.branch-1-win.1.patch, HADOOP-8847.branch-1-win.2.patch, HADOOP-8847.branch-1-win.3.patch, HADOOP-8847.branch-1-win.4.patch, test-untar.tar, test-untar.tgz
>
>
> Currently FileUtil.unTar() spawns tar utility to do the work. Tar may not be present on all platforms by default eg. Windows. So changing this to use JAVA API's would help make it more cross-platform. FileUtil.unZip() uses the same approach.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8847) Change untar to use Java API
instead of spawning tar process
Posted by "Bikas Saha (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13485975#comment-13485975 ]
Bikas Saha commented on HADOOP-8847:
------------------------------------
Ping
> Change untar to use Java API instead of spawning tar process
> ------------------------------------------------------------
>
> Key: HADOOP-8847
> URL: https://issues.apache.org/jira/browse/HADOOP-8847
> Project: Hadoop Common
> Issue Type: Improvement
> Reporter: Bikas Saha
> Assignee: Bikas Saha
> Attachments: HADOOP-8847.branch-1-win.1.patch, HADOOP-8847.branch-1-win.2.patch, test-untar.tar, test-untar.tgz
>
>
> Currently FileUtil.unTar() spawns tar utility to do the work. Tar may not be present on all platforms by default eg. Windows. So changing this to use JAVA API's would help make it more cross-platform. FileUtil.unZip() uses the same approach.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8847) Change untar to use Java API
instead of spawning tar process
Posted by "Robert Joseph Evans (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13463958#comment-13463958 ]
Robert Joseph Evans commented on HADOOP-8847:
---------------------------------------------
Steve, what do you mean by losing file permissions? does that mean that all files will be created with the default umask permissions? That could cause major problems for people who ship executables inside a tgz. I thought at one point we were post processing the contents of a .zip to give everything execute permissions. If we are doing that the tgzs as well as the zips it may not be that big of a deal, but I would still be nervous about a change like that.
> Change untar to use Java API instead of spawning tar process
> ------------------------------------------------------------
>
> Key: HADOOP-8847
> URL: https://issues.apache.org/jira/browse/HADOOP-8847
> Project: Hadoop Common
> Issue Type: Improvement
> Reporter: Bikas Saha
> Assignee: Bikas Saha
> Attachments: HADOOP-8847.branch-1-win.1.patch, test-untar.tar, test-untar.tgz
>
>
> Currently FileUtil.unTar() spawns tar utility to do the work. Tar may not be present on all platforms by default eg. Windows. So changing this to use JAVA API's would help make it more cross-platform. FileUtil.unZip() uses the same approach.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8847) Change untar to use Java API
instead of spawning tar process
Posted by "Steve Loughran (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13463638#comment-13463638 ]
Steve Loughran commented on HADOOP-8847:
----------------------------------------
Bikas, you know that the java untar doesn't set FS permissions? Even if that's considered unimportant, the big worry I have is over long filenames.
The Ant tar/untar logic doesn't do perms either, but does handle gnu & posix extensions:
[ http://svn.apache.org/viewvc/ant/core/trunk/src/main/org/apache/tools/tar/ ]
you can pick this up via Apache Compress: [ http://commons.apache.org/compress/ ] -I'm not sure that version is up to date w/ Posix patches.
You need tests to verify that
# filenames > 140 chars can be untarred (tar --format=gnu )
# LFNs in old gnu format are handled (tar --format=oldgnu)
# long filenames in a tar created w/ posix (tar --format=posix)
These files could all be created on a Linux box and added to svn, so that the tests on windows will be consistent.
Without tests showing that long filenames are handled, switching to a pure Java API will not be backwards compatible and runs a risk of things breaking. Sun's implementation cannot handle such files.
> Change untar to use Java API instead of spawning tar process
> ------------------------------------------------------------
>
> Key: HADOOP-8847
> URL: https://issues.apache.org/jira/browse/HADOOP-8847
> Project: Hadoop Common
> Issue Type: Improvement
> Reporter: Bikas Saha
> Assignee: Bikas Saha
> Attachments: HADOOP-8847.branch-1-win.1.patch, test-untar.tar, test-untar.tgz
>
>
> Currently FileUtil.unTar() spawns tar utility to do the work. Tar may not be present on all platforms by default eg. Windows. So changing this to use JAVA API's would help make it more cross-platform. FileUtil.unZip() uses the same approach.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-8847) Change untar to use Java API instead
of spawning tar process
Posted by "Suresh Srinivas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8847?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Suresh Srinivas updated HADOOP-8847:
------------------------------------
Attachment: HADOOP-8847.branch-1-win.4.patch
Minor update to the patch to make else clause follow coding convention.
+1 for the patch. If there are no further comments, I will commit this patch by the end of the day today. If folks come with comments later, it could be addressed in a followup jira.
> Change untar to use Java API instead of spawning tar process
> ------------------------------------------------------------
>
> Key: HADOOP-8847
> URL: https://issues.apache.org/jira/browse/HADOOP-8847
> Project: Hadoop Common
> Issue Type: Improvement
> Affects Versions: 1-win
> Reporter: Bikas Saha
> Assignee: Bikas Saha
> Attachments: HADOOP-8847.branch-1-win.1.patch, HADOOP-8847.branch-1-win.2.patch, HADOOP-8847.branch-1-win.3.patch, HADOOP-8847.branch-1-win.4.patch, test-untar.tar, test-untar.tgz
>
>
> Currently FileUtil.unTar() spawns tar utility to do the work. Tar may not be present on all platforms by default eg. Windows. So changing this to use JAVA API's would help make it more cross-platform. FileUtil.unZip() uses the same approach.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8847) Change untar to use Java API
instead of spawning tar process
Posted by "Bikas Saha (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13468361#comment-13468361 ]
Bikas Saha commented on HADOOP-8847:
------------------------------------
Java File.setExecutable/File.setWritable dont work as expected on Windows. In any case, the distributed cache explicitly sets permissions on untar'd files after expanding archives. So there should be no problem. Here is the code snippet from TrackerDistributedCacheManager.downloadCacheObject(). See end of snippet.
{code}
if (isArchive) {
String tmpArchive = workFile.getName().toLowerCase();
File srcFile = new File(workFile.toString());
File destDir = new File(workDir.toString());
LOG.info(String.format("Extracting %s to %s",
srcFile.toString(), destDir.toString()));
if (tmpArchive.endsWith(".jar")) {
RunJar.unJar(srcFile, destDir);
} else if (tmpArchive.endsWith(".zip")) {
FileUtil.unZip(srcFile, destDir);
} else if (isTarFile(tmpArchive)) {
FileUtil.unTar(srcFile, destDir);
} else {
LOG.warn(String.format(
"Cache file %s specified as archive, but not valid extension.",
srcFile.toString()));
// else will not do anyhting
// and copy the file into the dir as it is
}
FileUtil.chmod(destDir.toString(), "ugo+rx", true);
}
{code}
If you are really worried about this change then I could continue to use existing spawn tar impl for Linux.
> Change untar to use Java API instead of spawning tar process
> ------------------------------------------------------------
>
> Key: HADOOP-8847
> URL: https://issues.apache.org/jira/browse/HADOOP-8847
> Project: Hadoop Common
> Issue Type: Improvement
> Reporter: Bikas Saha
> Assignee: Bikas Saha
> Attachments: HADOOP-8847.branch-1-win.1.patch, test-untar.tar, test-untar.tgz
>
>
> Currently FileUtil.unTar() spawns tar utility to do the work. Tar may not be present on all platforms by default eg. Windows. So changing this to use JAVA API's would help make it more cross-platform. FileUtil.unZip() uses the same approach.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-8847) Change untar to use Java API instead
of spawning tar process
Posted by "Suresh Srinivas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8847?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Suresh Srinivas updated HADOOP-8847:
------------------------------------
Affects Version/s: 1-win
> Change untar to use Java API instead of spawning tar process
> ------------------------------------------------------------
>
> Key: HADOOP-8847
> URL: https://issues.apache.org/jira/browse/HADOOP-8847
> Project: Hadoop Common
> Issue Type: Improvement
> Affects Versions: 1-win
> Reporter: Bikas Saha
> Assignee: Bikas Saha
> Attachments: HADOOP-8847.branch-1-win.1.patch, HADOOP-8847.branch-1-win.2.patch, HADOOP-8847.branch-1-win.3.patch, test-untar.tar, test-untar.tgz
>
>
> Currently FileUtil.unTar() spawns tar utility to do the work. Tar may not be present on all platforms by default eg. Windows. So changing this to use JAVA API's would help make it more cross-platform. FileUtil.unZip() uses the same approach.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-8847) Change untar to use Java API instead
of spawning tar process
Posted by "Bikas Saha (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8847?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bikas Saha updated HADOOP-8847:
-------------------------------
Status: Open (was: Patch Available)
> Change untar to use Java API instead of spawning tar process
> ------------------------------------------------------------
>
> Key: HADOOP-8847
> URL: https://issues.apache.org/jira/browse/HADOOP-8847
> Project: Hadoop Common
> Issue Type: Improvement
> Reporter: Bikas Saha
> Assignee: Bikas Saha
> Attachments: HADOOP-8847.branch-1-win.1.patch, HADOOP-8847.branch-1-win.2.patch, test-untar.tar, test-untar.tgz
>
>
> Currently FileUtil.unTar() spawns tar utility to do the work. Tar may not be present on all platforms by default eg. Windows. So changing this to use JAVA API's would help make it more cross-platform. FileUtil.unZip() uses the same approach.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8847) Change untar to use Java API
instead of spawning tar process
Posted by "Robert Joseph Evans (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13464823#comment-13464823 ]
Robert Joseph Evans commented on HADOOP-8847:
---------------------------------------------
bq. tar perms are only going to matter in Unix-land, so perhaps the strategy here is to make the java untar the default on windows, but not the default on other platforms.
I am fine with that. Even setting the permissions though File.setExecutable and File.setWritable should be good enough on the user and application cache. It really only starts to matter for the public cache. This is because the Java permissions only impact the user permissions, and not the group or world permissions. In the public cache a different user will be reading the files from the one that wrote them, in all of the others it should be the exact same user.
> Change untar to use Java API instead of spawning tar process
> ------------------------------------------------------------
>
> Key: HADOOP-8847
> URL: https://issues.apache.org/jira/browse/HADOOP-8847
> Project: Hadoop Common
> Issue Type: Improvement
> Reporter: Bikas Saha
> Assignee: Bikas Saha
> Attachments: HADOOP-8847.branch-1-win.1.patch, test-untar.tar, test-untar.tgz
>
>
> Currently FileUtil.unTar() spawns tar utility to do the work. Tar may not be present on all platforms by default eg. Windows. So changing this to use JAVA API's would help make it more cross-platform. FileUtil.unZip() uses the same approach.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8847) Change untar to use Java API
instead of spawning tar process
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13498276#comment-13498276 ]
Hadoop QA commented on HADOOP-8847:
-----------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12553687/HADOOP-8847.branch-1-win.4.patch
against trunk revision .
{color:red}-1 patch{color}. The patch command could not apply the patch.
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/1753//console
This message is automatically generated.
> Change untar to use Java API instead of spawning tar process
> ------------------------------------------------------------
>
> Key: HADOOP-8847
> URL: https://issues.apache.org/jira/browse/HADOOP-8847
> Project: Hadoop Common
> Issue Type: Improvement
> Affects Versions: 1-win
> Reporter: Bikas Saha
> Assignee: Bikas Saha
> Attachments: HADOOP-8847.branch-1-win.1.patch, HADOOP-8847.branch-1-win.2.patch, HADOOP-8847.branch-1-win.3.patch, HADOOP-8847.branch-1-win.4.patch, test-untar.tar, test-untar.tgz
>
>
> Currently FileUtil.unTar() spawns tar utility to do the work. Tar may not be present on all platforms by default eg. Windows. So changing this to use JAVA API's would help make it more cross-platform. FileUtil.unZip() uses the same approach.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-8847) Change untar to use Java API instead
of spawning tar process
Posted by "Bikas Saha (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8847?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bikas Saha updated HADOOP-8847:
-------------------------------
Attachment: test-untar.tgz
test-untar.tar
> Change untar to use Java API instead of spawning tar process
> ------------------------------------------------------------
>
> Key: HADOOP-8847
> URL: https://issues.apache.org/jira/browse/HADOOP-8847
> Project: Hadoop Common
> Issue Type: Improvement
> Reporter: Bikas Saha
> Assignee: Bikas Saha
> Attachments: test-untar.tar, test-untar.tgz
>
>
> Currently FileUtil.unTar() spawns tar utility to do the work. Tar may not be present on all platforms by default eg. Windows. So changing this to use JAVA API's would help make it more cross-platform. FileUtil.unZip() uses the same approach.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8847) Change untar to use Java API
instead of spawning tar process
Posted by "Bikas Saha (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13463446#comment-13463446 ]
Bikas Saha commented on HADOOP-8847:
------------------------------------
Attaching patch that uses JAVA apache commons api to do untar. Adds a test that does a sanity check.
I have written a manual test that untars a tar file 10 times using old and new methods and both have similar perf. Not adding that test because it takes a long time to run.
Attaching 2 test resource files. The patch file has the locations where these resources need to be committed.
> Change untar to use Java API instead of spawning tar process
> ------------------------------------------------------------
>
> Key: HADOOP-8847
> URL: https://issues.apache.org/jira/browse/HADOOP-8847
> Project: Hadoop Common
> Issue Type: Improvement
> Reporter: Bikas Saha
> Assignee: Bikas Saha
> Attachments: HADOOP-8847.branch-1-win.1.patch, test-untar.tar, test-untar.tgz
>
>
> Currently FileUtil.unTar() spawns tar utility to do the work. Tar may not be present on all platforms by default eg. Windows. So changing this to use JAVA API's would help make it more cross-platform. FileUtil.unZip() uses the same approach.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8847) Change untar to use Java API
instead of spawning tar process
Posted by "Steve Loughran (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13468473#comment-13468473 ]
Steve Loughran commented on HADOOP-8847:
----------------------------------------
that code snippet shows that the dest dir perms are setup -but doesn't touch the contents of the files itself. If someone needs x permissions on binaries there then there's a regression risk here -which is what Robert sounds like he's going to hit
> Change untar to use Java API instead of spawning tar process
> ------------------------------------------------------------
>
> Key: HADOOP-8847
> URL: https://issues.apache.org/jira/browse/HADOOP-8847
> Project: Hadoop Common
> Issue Type: Improvement
> Reporter: Bikas Saha
> Assignee: Bikas Saha
> Attachments: HADOOP-8847.branch-1-win.1.patch, test-untar.tar, test-untar.tgz
>
>
> Currently FileUtil.unTar() spawns tar utility to do the work. Tar may not be present on all platforms by default eg. Windows. So changing this to use JAVA API's would help make it more cross-platform. FileUtil.unZip() uses the same approach.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-8847) Change untar to use Java API instead
of spawning tar process
Posted by "Bikas Saha (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8847?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bikas Saha updated HADOOP-8847:
-------------------------------
Attachment: HADOOP-8847.branch-1-win.2.patch
Attaching patch that restores previous behavior for non Windows. The test-untar* files need to be added to src/test/org/apache/hadoop/fs/ to complete the patch and commit it.
> Change untar to use Java API instead of spawning tar process
> ------------------------------------------------------------
>
> Key: HADOOP-8847
> URL: https://issues.apache.org/jira/browse/HADOOP-8847
> Project: Hadoop Common
> Issue Type: Improvement
> Reporter: Bikas Saha
> Assignee: Bikas Saha
> Attachments: HADOOP-8847.branch-1-win.1.patch, HADOOP-8847.branch-1-win.2.patch, test-untar.tar, test-untar.tgz
>
>
> Currently FileUtil.unTar() spawns tar utility to do the work. Tar may not be present on all platforms by default eg. Windows. So changing this to use JAVA API's would help make it more cross-platform. FileUtil.unZip() uses the same approach.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8847) Change untar to use Java API
instead of spawning tar process
Posted by "Robert Joseph Evans (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13471828#comment-13471828 ]
Robert Joseph Evans commented on HADOOP-8847:
---------------------------------------------
One thing to be aware of when porting this to trunk is that YARN is not doing the FileUtil.chmod. I don't think this will impact you for the windows port. I just thought I should mention it.
> Change untar to use Java API instead of spawning tar process
> ------------------------------------------------------------
>
> Key: HADOOP-8847
> URL: https://issues.apache.org/jira/browse/HADOOP-8847
> Project: Hadoop Common
> Issue Type: Improvement
> Reporter: Bikas Saha
> Assignee: Bikas Saha
> Attachments: HADOOP-8847.branch-1-win.1.patch, HADOOP-8847.branch-1-win.2.patch, test-untar.tar, test-untar.tgz
>
>
> Currently FileUtil.unTar() spawns tar utility to do the work. Tar may not be present on all platforms by default eg. Windows. So changing this to use JAVA API's would help make it more cross-platform. FileUtil.unZip() uses the same approach.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8847) Change untar to use Java API
instead of spawning tar process
Posted by "Bikas Saha (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13479204#comment-13479204 ]
Bikas Saha commented on HADOOP-8847:
------------------------------------
I havent used any try finally blocks because I want untar to fail if there is any error on any operation.
> Change untar to use Java API instead of spawning tar process
> ------------------------------------------------------------
>
> Key: HADOOP-8847
> URL: https://issues.apache.org/jira/browse/HADOOP-8847
> Project: Hadoop Common
> Issue Type: Improvement
> Reporter: Bikas Saha
> Assignee: Bikas Saha
> Attachments: HADOOP-8847.branch-1-win.1.patch, HADOOP-8847.branch-1-win.2.patch, test-untar.tar, test-untar.tgz
>
>
> Currently FileUtil.unTar() spawns tar utility to do the work. Tar may not be present on all platforms by default eg. Windows. So changing this to use JAVA API's would help make it more cross-platform. FileUtil.unZip() uses the same approach.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8847) Change untar to use Java API
instead of spawning tar process
Posted by "Bikas Saha (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13469164#comment-13469164 ]
Bikas Saha commented on HADOOP-8847:
------------------------------------
I am going to restore old behavior for non Windows case. I dont see much value in re-implementing all idiosyncrasies and features of unix tar in Java. The Java implementation was to give a good enough implementation that meets the use case of users submitting tar archives for distributed cache files. There are some tests which validate this functionality and these were failing on Windows. Most likely users will submit simple tar files to distributed cache. Windows users will likely submit zip files and not tar files since tar is not native to windows. Hence I will re-submit the patch which uses Java code only on Windows.
> Change untar to use Java API instead of spawning tar process
> ------------------------------------------------------------
>
> Key: HADOOP-8847
> URL: https://issues.apache.org/jira/browse/HADOOP-8847
> Project: Hadoop Common
> Issue Type: Improvement
> Reporter: Bikas Saha
> Assignee: Bikas Saha
> Attachments: HADOOP-8847.branch-1-win.1.patch, test-untar.tar, test-untar.tgz
>
>
> Currently FileUtil.unTar() spawns tar utility to do the work. Tar may not be present on all platforms by default eg. Windows. So changing this to use JAVA API's would help make it more cross-platform. FileUtil.unZip() uses the same approach.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-8847) Change untar to use Java API instead
of spawning tar process
Posted by "Bikas Saha (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8847?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bikas Saha updated HADOOP-8847:
-------------------------------
Status: Patch Available (was: Open)
> Change untar to use Java API instead of spawning tar process
> ------------------------------------------------------------
>
> Key: HADOOP-8847
> URL: https://issues.apache.org/jira/browse/HADOOP-8847
> Project: Hadoop Common
> Issue Type: Improvement
> Reporter: Bikas Saha
> Assignee: Bikas Saha
> Attachments: HADOOP-8847.branch-1-win.1.patch, test-untar.tar, test-untar.tgz
>
>
> Currently FileUtil.unTar() spawns tar utility to do the work. Tar may not be present on all platforms by default eg. Windows. So changing this to use JAVA API's would help make it more cross-platform. FileUtil.unZip() uses the same approach.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-8847) Change untar to use Java API instead
of spawning tar process
Posted by "Bikas Saha (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8847?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bikas Saha updated HADOOP-8847:
-------------------------------
Attachment: HADOOP-8847.branch-1-win.1.patch
> Change untar to use Java API instead of spawning tar process
> ------------------------------------------------------------
>
> Key: HADOOP-8847
> URL: https://issues.apache.org/jira/browse/HADOOP-8847
> Project: Hadoop Common
> Issue Type: Improvement
> Reporter: Bikas Saha
> Assignee: Bikas Saha
> Attachments: HADOOP-8847.branch-1-win.1.patch, test-untar.tar, test-untar.tgz
>
>
> Currently FileUtil.unTar() spawns tar utility to do the work. Tar may not be present on all platforms by default eg. Windows. So changing this to use JAVA API's would help make it more cross-platform. FileUtil.unZip() uses the same approach.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8847) Change untar to use Java API
instead of spawning tar process
Posted by "Bikas Saha (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13468675#comment-13468675 ]
Bikas Saha commented on HADOOP-8847:
------------------------------------
The true argument at the end is for recursive descent. So everything gets chmod'd.
> Change untar to use Java API instead of spawning tar process
> ------------------------------------------------------------
>
> Key: HADOOP-8847
> URL: https://issues.apache.org/jira/browse/HADOOP-8847
> Project: Hadoop Common
> Issue Type: Improvement
> Reporter: Bikas Saha
> Assignee: Bikas Saha
> Attachments: HADOOP-8847.branch-1-win.1.patch, test-untar.tar, test-untar.tgz
>
>
> Currently FileUtil.unTar() spawns tar utility to do the work. Tar may not be present on all platforms by default eg. Windows. So changing this to use JAVA API's would help make it more cross-platform. FileUtil.unZip() uses the same approach.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira