Re: cvs commit: jakarta-tomcat/src/share/org/apache/tomcat/service/http HttpRequestAdapter.java

["Craig R. McClanahan" <Cr...@eng.sun.com>]

Larry Isaacs wrote:

> Craig,
>
> Thanks for implementing the fix.  I ran into this problem trying to get the test-tomcat.xml to run without hanging.  However, your comments suggest that test-tomcat.xml, which sends requests with "HTTP/0.9" on the end, is the one in error.  Not being an expert on HTTP, I assumed the tests were correct.
>

I would have thought so too.  I will do some more checking on the specs.

>
> Since, it appears this hang and some other problems have been in test-tomcal.xml for a while, and it is not currently documented in the users guide, what is the intent for test-tomcat.xml?  Is it planned to be part of the release and expected to run without hangs or errors?
>

Yes, these should run without errors.  While test-tomcat is not as thorough as Watchdog for checking compliance, it runs a lot faster, and can give Tomcat developers a quick sanity check that they haven't broken something important.

>
> Assuming it will be present in the release, would you like me to log a bug against test-tomcat.xml for sending "HTTP/0.9" as part of the request?  I encountered two other problems getting test-tomcat.xml to run successfully without error.  Should I proceed with logging these?
>

Please do log any bugs you find in the test suite.  If I have time this morning, I'll add a component category for the tests in Bugzilla -- otherwise, just use "other".

>
> Thanks. Your efforts with Tomcat are greatly appreciated.
>

Likewise, thanks for the useful and succinct bug reports (to say nothing of bug fixes as well :-).

>
> Larry
>

Craig


>
> -----Original Message-----
> From: craigmcc@locus.apache.org [mailto:craigmcc@locus.apache.org]
> Sent: Monday, March 27, 2000 10:40 PM
> To: jakarta-tomcat-cvs@apache.org
> Subject: cvs commit:
> jakarta-tomcat/src/share/org/apache/tomcat/service/http
> HttpRequestAdapter.java
>
> craigmcc    00/03/27 19:40:00
>
>   Modified:    src/share/org/apache/tomcat/service/http
>                         HttpRequestAdapter.java
>   Log:
>   Patch HttpRequestAdapter to not hang on a POST when "HTTP/0.9" is included
>   in the request.  From my reading of the specs, it seems that a client that
>   sends HTTP/0.9 on the request line is broken (it should only be sending
>   GET plus the request URI), but what the heck.
>   PR:117
>   Submitted by: Larry.Isaacs@sas.com
>
>   Revision  Changes    Path
>   1.8       +5 -4      jakarta-tomcat/src/share/org/apache/tomcat/service/http/HttpRequestAdapter.java
>
>   Index: HttpRequestAdapter.java
>   ===================================================================
>   RCS file: /home/cvs/jakarta-tomcat/src/share/org/apache/tomcat/service/http/HttpRequestAdapter.java,v
>   retrieving revision 1.7
>   retrieving revision 1.8
>   diff -u -r1.7 -r1.8
>   --- HttpRequestAdapter.java   2000/02/18 00:17:49     1.7
>   +++ HttpRequestAdapter.java   2000/03/28 03:40:00     1.8
>   @@ -1,7 +1,7 @@
>    /*
>   - * $Header: /home/cvs/jakarta-tomcat/src/share/org/apache/tomcat/service/http/HttpRequestAdapter.java,v 1.7 2000/02/18 00:17:49 costin Exp $
>   - * $Revision: 1.7 $
>   - * $Date: 2000/02/18 00:17:49 $
>   + * $Header: /home/cvs/jakarta-tomcat/src/share/org/apache/tomcat/service/http/HttpRequestAdapter.java,v 1.8 2000/03/28 03:40:00 craigmcc Exp $
>   + * $Revision: 1.8 $
>   + * $Date: 2000/03/28 03:40:00 $
>     *
>     * ====================================================================
>     *
>   @@ -128,7 +128,8 @@
>         //      }
>
>         // for 0.9, we don't have headers!
>   -     if(protocol!=null)
>   +     if ((protocol!=null) &&
>   +            !protocol.toLowerCase().startsWith("http/0."))
>             headers.read(in);
>         //      processCookies(); // called later
>
>
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: tomcat-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: tomcat-dev-help@jakarta.apache.org
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: tomcat-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: tomcat-dev-help@jakarta.apache.org