You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2020/11/12 22:06:52 UTC

[GitHub] [geode] sabbey37 opened a new pull request #5745: GEODE-8704: many CI failures in Jetty9CachingClientServerTest

sabbey37 opened a new pull request #5745:
URL: https://github.com/apache/geode/pull/5745


   Ignoring this test class until issue with JDK update is resolved.
   
   Thank you for submitting a contribution to Apache Geode.
   
   In order to streamline the review of the contribution we ask you
   to ensure the following steps have been taken:
   
   ### For all changes:
   - [ x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
   
   - [ x] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?
   
   - [ x] Is your initial contribution a single, squashed commit?
   
   - [ x] Does `gradlew build` run cleanly?
   
   - [ x] Have you written or updated unit tests to verify your changes?
   
   - [ x] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
   
   ### Note:
   Please ensure that once the PR is submitted, check Concourse for build issues and
   submit an update to your PR as soon as possible. If you need help, please send an
   email to dev@geode.apache.org.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [geode] kohlmu-pivotal commented on a change in pull request #5745: GEODE-8704: many CI failures in Jetty9CachingClientServerTest

Posted by GitBox <gi...@apache.org>.
kohlmu-pivotal commented on a change in pull request #5745:
URL: https://github.com/apache/geode/pull/5745#discussion_r522502627



##########
File path: geode-assembly/src/distributedTest/java/org/apache/geode/session/tests/Jetty9CachingClientServerTest.java
##########
@@ -23,12 +23,14 @@
 
 import javax.servlet.http.HttpSession;
 
+import org.junit.Ignore;
 import org.junit.Test;
 
 import org.apache.geode.cache.Region;
 import org.apache.geode.internal.cache.InternalCache;
 import org.apache.geode.test.dunit.rules.ClusterStartupRule;
 
+@Ignore("GEODE-8704")

Review comment:
       Why are ignoring these tests?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [geode] sabbey37 merged pull request #5745: GEODE-8704: many CI failures in Jetty9CachingClientServerTest

Posted by GitBox <gi...@apache.org>.
sabbey37 merged pull request #5745:
URL: https://github.com/apache/geode/pull/5745


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [geode] BenjaminPerryRoss commented on a change in pull request #5745: GEODE-8704: many CI failures in Jetty9CachingClientServerTest

Posted by GitBox <gi...@apache.org>.
BenjaminPerryRoss commented on a change in pull request #5745:
URL: https://github.com/apache/geode/pull/5745#discussion_r522519835



##########
File path: geode-assembly/src/distributedTest/java/org/apache/geode/session/tests/Jetty9CachingClientServerTest.java
##########
@@ -23,12 +23,14 @@
 
 import javax.servlet.http.HttpSession;
 
+import org.junit.Ignore;
 import org.junit.Test;
 
 import org.apache.geode.cache.Region;
 import org.apache.geode.internal.cache.InternalCache;
 import org.apache.geode.test.dunit.rules.ClusterStartupRule;
 
+@Ignore("GEODE-8704")

Review comment:
       These tests are causing pipeline failures following a JDK version update. Since it's only tests in this class, we opted to ignore the tests while we fix the issue to unblock the pipeline.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org