You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jclouds.apache.org by Andrew Gaul <no...@github.com> on 2013/08/27 08:21:23 UTC
[jclouds] Simplify testPutFileParallel (#130)
Create only one temporary file and use explicit delete instead
finalization to remove it.
You can merge this Pull Request by running:
git pull https://github.com/maginatics/jclouds simplify-test-put-file-parallel
Or you can view, comment on it, or merge it online at:
https://github.com/jclouds/jclouds/pull/130
-- Commit Summary --
* Simplify testPutFileParallel
-- File Changes --
M blobstore/src/test/java/org/jclouds/blobstore/integration/internal/BaseBlobIntegrationTest.java (11)
-- Patch Links --
https://github.com/jclouds/jclouds/pull/130.patch
https://github.com/jclouds/jclouds/pull/130.diff
Re: [jclouds] Simplify testPutFileParallel (#130)
Posted by Andrew Phillips <no...@github.com>.
One small comment, otherwise +1
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/130#issuecomment-23343503
Re: [jclouds] Simplify testPutFileParallel (#130)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-pull-requests #178](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/178/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/130#issuecomment-23317105
Re: [jclouds] Simplify testPutFileParallel (#130)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-java-7-pull-requests #643](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/643/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/130#issuecomment-23369737
Re: [jclouds] Simplify testPutFileParallel (#130)
Posted by Andrew Phillips <no...@github.com>.
> @@ -173,6 +172,7 @@ public Void call() throws Exception {
>
> } finally {
> returnContainer(container);
> + payloadFile.delete();
Can `returnContainer` fail and cause this not to be run?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/130/files#r6007285
Re: [jclouds] Simplify testPutFileParallel (#130)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-pull-requests #182](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/182/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/130#issuecomment-23369719
Re: [jclouds] Simplify testPutFileParallel (#130)
Posted by BuildHive <no...@github.com>.
[jclouds ยป jclouds #350](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/350/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/130#issuecomment-23317566
Re: [jclouds] Simplify testPutFileParallel (#130)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-java-7-pull-requests #638](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/638/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/130#issuecomment-23317108
Re: [jclouds] Simplify testPutFileParallel (#130)
Posted by Andrew Gaul <no...@github.com>.
Closed #130.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/130
Re: [jclouds] Simplify testPutFileParallel (#130)
Posted by Andrew Gaul <no...@github.com>.
> @@ -173,6 +172,7 @@ public Void call() throws Exception {
>
> } finally {
> returnContainer(container);
> + payloadFile.delete();
Let's swap these for now, but generally this is a tough problem in Java 6.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/130/files#r6016415