You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by "kfeng123 (via GitHub)" <gi...@apache.org> on 2023/04/10 07:14:52 UTC

[GitHub] [tvm] kfeng123 opened a new pull request, #14556: [Bugfix] [Relay] fix a bug caused by IncompleteTypeNode in EinsumRel while doing MergeComposite

kfeng123 opened a new pull request, #14556:
URL: https://github.com/apache/tvm/pull/14556

   Previously, it was reported that when using MergeComposite on a model with broadcast_to OP, an error caused by IncompleteTypeNode occurs during compiling model. See https://discuss.tvm.apache.org/t/incomplete-type-in-broadcasttorel-while-doing-mergecomposite/10439
   
   A similar bug also occurs if the model contains einsum OP. And this PR fix this bug for einsum OP.
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] kfeng123 commented on pull request #14556: [Bugfix] [Relay] fix a bug caused by IncompleteTypeNode in EinsumRel while doing MergeComposite

Posted by "kfeng123 (via GitHub)" <gi...@apache.org>.
kfeng123 commented on PR #14556:
URL: https://github.com/apache/tvm/pull/14556#issuecomment-1501489363

   cc @comaniac


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] kfeng123 commented on pull request #14556: [Bugfix] [Relay] fix a bug caused by IncompleteTypeNode in EinsumRel while doing MergeComposite

Posted by "kfeng123 (via GitHub)" <gi...@apache.org>.
kfeng123 commented on PR #14556:
URL: https://github.com/apache/tvm/pull/14556#issuecomment-1501801094

   > LGTM. Can you add a unit test?
   
   Hi, I have added a test case of MergeComposite: the old code crashed and the updated code works correctly.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] tqchen merged pull request #14556: [Bugfix] [Relay] fix a bug caused by IncompleteTypeNode in EinsumRel while doing MergeComposite

Posted by "tqchen (via GitHub)" <gi...@apache.org>.
tqchen merged PR #14556:
URL: https://github.com/apache/tvm/pull/14556


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] tvm-bot commented on pull request #14556: [Bugfix] [Relay] fix a bug caused by IncompleteTypeNode in EinsumRel while doing MergeComposite

Posted by "tvm-bot (via GitHub)" <gi...@apache.org>.
tvm-bot commented on PR #14556:
URL: https://github.com/apache/tvm/pull/14556#issuecomment-1501488874

   <!---bot-comment-->
   
   Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from [Reviewers](https://github.com/apache/incubator-tvm/blob/master/CONTRIBUTORS.md#reviewers) by @-ing them in a comment.
   
   <!--bot-comment-ccs-start-->
    * cc @shingjan <sub>See [#10317](https://github.com/apache/tvm/issues/10317) for details</sub><!--bot-comment-ccs-end-->
   
   <sub>Generated by [tvm-bot](https://github.com/apache/tvm/blob/main/ci/README.md#github-actions)</sub>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] comaniac commented on pull request #14556: [Bugfix] [Relay] fix a bug caused by IncompleteTypeNode in EinsumRel while doing MergeComposite

Posted by "comaniac (via GitHub)" <gi...@apache.org>.
comaniac commented on PR #14556:
URL: https://github.com/apache/tvm/pull/14556#issuecomment-1501540470

   LGTM. Can you add a unit test?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org