[GitHub] wolfmanfx commented on a change in pull request #545: Do not overwrite all targets with same id

[GitBox <gi...@apache.org>]

wolfmanfx commented on a change in pull request #545: Do not overwrite all targets with same id
URL: https://github.com/apache/cordova-ios/pull/545#discussion_r260027411
 
 

 ##########
 File path: bin/templates/scripts/cordova/lib/prepare.js
 ##########
 @@ -275,12 +275,59 @@ function handleOrientationSettings (platformConfig, infoPlist) {
     }
 }
 
+// Make sure only update properties from our target project
+function updateBuildPropertyLocal(proj, displayName, prop, value, build) {
+    try {
+        // Check if we have a valid target - during prepare we do not have it
+        var target = proj.pbxTargetByName(displayName);
 
 Review comment:
   Yes you were right - I have fixed the pbx target retrieval (tried both variants)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org