[jira] [Commented] (AIRFLOW-384) Use params property for all request types in HTTP Hook

["Sergio Kef (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AIRFLOW-384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16940133#comment-16940133 ] 

Sergio Kef commented on AIRFLOW-384:
------------------------------------

This is already implemented. Can we close this?

> Use params property for all request types in HTTP Hook
> ------------------------------------------------------
>
>                 Key: AIRFLOW-384
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-384
>             Project: Apache Airflow
>          Issue Type: Bug
>          Components: hooks
>            Reporter: Christopher Quinones
>            Assignee: Christopher Quinones
>            Priority: Minor
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> In order to pass params to http hooks, one is required to add them directly to the endpoint.  The requests package already supports passing a dictionary of params into it to avoid adding extra logic at the DAG level.
> Adopt params in http_hook.py.  This also ensures that params are not printed to the console.  In some of my use cases, parameters are secure and should not be printed into the airflow DAG output.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)