[GitHub] [arrow-datafusion] tustvold commented on a diff in pull request #2312: Don't sort batches during plan

[GitBox <gi...@apache.org>]

tustvold commented on code in PR #2312:
URL: https://github.com/apache/arrow-datafusion/pull/2312#discussion_r855466582


##########
datafusion/core/src/physical_plan/stream.rs:
##########
@@ -73,3 +74,45 @@ impl RecordBatchStream for RecordBatchReceiverStream {
         self.schema.clone()
     }
 }
+
+/// Combines a [`BoxStream`] with [`SchemaRef`] implementing
+/// [`RecordBatchStream`] for the combination
+pub(crate) struct RecordBatchBoxStream {

Review Comment:
   I'm not a massive fan of this, as it results in double dyn-dispatch, but it is probably acceptable until such a time as we rework ExecutionPlan.
   
   I've put this alongside RecordBatchReceiverStream as it is likely generally useful, but I've kept it pub(crate) as I'm not sure how long this interface will be around for



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org