You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@drill.apache.org by arina-ielchiieva <gi...@git.apache.org> on 2017/12/05 17:32:16 UTC

[GitHub] drill pull request #1062: DRILL-6007: Use default refresh timeout (10 second...

GitHub user arina-ielchiieva opened a pull request:

    https://github.com/apache/drill/pull/1062

    DRILL-6007: Use default refresh timeout (10 seconds) if graceful shut…

    …down timeout is set to 0.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/arina-ielchiieva/drill DRILL-6007

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/drill/pull/1062.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1062
    
----
commit a4e1b8c4a48e39465cda40052a97cf07a05a404c
Author: Arina Ielchiieva <ar...@gmail.com>
Date:   2017-12-05T17:13:09Z

    DRILL-6007: Use default refresh timeout (10 seconds) if graceful shutdown timeout is set to 0.

----


---

[GitHub] drill pull request #1062: DRILL-6007: Use default refresh timeout (10 second...

Posted by parthchandra <gi...@git.apache.org>.

Github user parthchandra commented on a diff in the pull request:

    https://github.com/apache/drill/pull/1062#discussion_r155875821
  
    --- Diff: exec/java-exec/src/main/resources/rest/index.ftl ---
    @@ -185,11 +185,10 @@
           </div>
       </div>
        <script charset="utf-8">
    -      var refreshTime = 2000;
    +      var refreshTime = 10000;
           var refresh = getRefreshTime();
    --- End diff --
    
    This is confusing isn't it? The function does not return a value and yet the return value (<undefined>) is stored in a variable that is not used. 
    Luckily it's not used anywhere. 



---

[GitHub] drill issue #1062: DRILL-6007: Use default refresh timeout (10 seconds) if g...

Posted by arina-ielchiieva <gi...@git.apache.org>.

Github user arina-ielchiieva commented on the issue:

    https://github.com/apache/drill/pull/1062
  
    Agree, I have created Jira for js part improvement where I have indicated some other things that should be improved (https://issues.apache.org/jira/browse/DRILL-6022).


---