You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pdfbox.apache.org by ti...@apache.org on 2023/02/02 18:47:00 UTC

svn commit: r1907225 - /pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/graphics/color/PDICCBased.java

Author: tilman
Date: Thu Feb  2 18:47:00 2023
New Revision: 1907225

URL: http://svn.apache.org/viewvc?rev=1907225&view=rev
Log:
PDFBOX-5563: refactor and trigger a ProfileDataException

Modified:
    pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/graphics/color/PDICCBased.java

Modified: pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/graphics/color/PDICCBased.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/graphics/color/PDICCBased.java?rev=1907225&r1=1907224&r2=1907225&view=diff
==============================================================================
--- pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/graphics/color/PDICCBased.java (original)
+++ pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/graphics/color/PDICCBased.java Thu Feb  2 18:47:00 2023
@@ -223,15 +223,15 @@ public final class PDICCBased extends PD
                 }
                 initialColor = new PDColor(initial, this);
 
-                if (IS_KCMS)
-                {
-                    // do things that trigger a ProfileDataException
-                    // or CMMException due to invalid profiles, see PDFBOX-1295 and PDFBOX-1740 (ü-file)
-                    // or ArrayIndexOutOfBoundsException, see PDFBOX-3610
-                    // also triggers a ProfileDataException for PDFBOX-3549 with KCMS
-                    awtColorSpace.toRGB(new float[getNumberOfComponents()]);
-                }
-                else
+                // do things that trigger a ProfileDataException
+                // or CMMException due to invalid profiles, see PDFBOX-1295 and PDFBOX-1740 (ü-file)
+                // or ArrayIndexOutOfBoundsException, see PDFBOX-3610
+                // also triggers a ProfileDataException for PDFBOX-3549 with KCMS
+                /// also triggers a ProfileDataException for PDFBOX-3549 with KCMS
+                // also triggers "CMMException: LCMS error 13" for PDFBOX-5563 with LCMS, but
+                // calling "new ComponentColorModel" doesn't
+                awtColorSpace.toRGB(new float[getNumberOfComponents()]);
+                if (!IS_KCMS)
                 {
                     // PDFBOX-4015: this one triggers "CMMException: LCMS error 13" with LCMS
                     new ComponentColorModel(awtColorSpace, false, false,