You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@uima.apache.org by "Richard Eckart de Castilho (JIRA)" <de...@uima.apache.org> on 2013/08/22 23:01:52 UTC
[jira] [Commented] (UIMA-3209) cleanup "additional parameters"
[ https://issues.apache.org/jira/browse/UIMA-3209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13747890#comment-13747890 ]
Richard Eckart de Castilho commented on UIMA-3209:
--------------------------------------------------
It would be nice to @Deprecate the misplaced ones.
> cleanup "additional parameters"
> -------------------------------
>
> Key: UIMA-3209
> URL: https://issues.apache.org/jira/browse/UIMA-3209
> Project: UIMA
> Issue Type: Improvement
> Components: Core Java Framework
> Affects Versions: 2.4.2SDK
> Reporter: Marshall Schor
> Priority: Minor
>
> Many user-facing APIs have a parameter, called additional parameters, which is a Map, for passing additional, arbitrary parameters.
> These APIs are often associated with user-facing interfaces, and have static final String constants that name the "keys" for these parameters.
> The placement of these static final String constants is not consistent. For example, there are duplicates ( both Resource and AnalysisEngine interfaces define "PARAM_CONFIG_PARAM_SETTINGS" ). It's probably worth checking to see if there are any missing, and if they are defined at the "right level". My guess is that moving these may break some user code; if so, I'd say it isn't worth removing misplaced ones. But I would add missing ones at the "right level", and make all other instances have their definition set to the the "master" (the one defined at the right level), so there's no doubt that duplicates are intended to have the same exact definition.
> The right level, I think, in a hierarchy of interface definitions, is the highest point for which the parameter makes sense (but not higher).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
Re: [jira] [Commented] (UIMA-3209) cleanup "additional parameters"
Posted by Marshall Schor <ms...@schor.com>.
+1
-Marshall
On 8/22/2013 5:01 PM, Richard Eckart de Castilho (JIRA) wrote:
> [ https://issues.apache.org/jira/browse/UIMA-3209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13747890#comment-13747890 ]
>
> Richard Eckart de Castilho commented on UIMA-3209:
> --------------------------------------------------
>
> It would be nice to @Deprecate the misplaced ones.
>
>> cleanup "additional parameters"
>> -------------------------------
>>
>> Key: UIMA-3209
>> URL: https://issues.apache.org/jira/browse/UIMA-3209
>> Project: UIMA
>> Issue Type: Improvement
>> Components: Core Java Framework
>> Affects Versions: 2.4.2SDK
>> Reporter: Marshall Schor
>> Priority: Minor
>>
>> Many user-facing APIs have a parameter, called additional parameters, which is a Map, for passing additional, arbitrary parameters.
>> These APIs are often associated with user-facing interfaces, and have static final String constants that name the "keys" for these parameters.
>> The placement of these static final String constants is not consistent. For example, there are duplicates ( both Resource and AnalysisEngine interfaces define "PARAM_CONFIG_PARAM_SETTINGS" ). It's probably worth checking to see if there are any missing, and if they are defined at the "right level". My guess is that moving these may break some user code; if so, I'd say it isn't worth removing misplaced ones. But I would add missing ones at the "right level", and make all other instances have their definition set to the the "master" (the one defined at the right level), so there's no doubt that duplicates are intended to have the same exact definition.
>> The right level, I think, in a hierarchy of interface definitions, is the highest point for which the parameter makes sense (but not higher).
> --
> This message is automatically generated by JIRA.
> If you think it was sent incorrectly, please contact your JIRA administrators
> For more information on JIRA, see: http://www.atlassian.com/software/jira
>