You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@shindig.apache.org by zh...@gmail.com on 2010/08/24 18:50:26 UTC

Re: [BugFix] Modifying JsonContainerConfig to add SERVER_HOST and SERVER_PORT env. to all containers (issue2000043)

http://codereview.appspot.com/2000043/diff/13001/5003
File
java/common/src/main/java/org/apache/shindig/config/JsonContainerConfig.java
(right):

http://codereview.appspot.com/2000043/diff/13001/5003#newcode90
java/common/src/main/java/org/apache/shindig/config/JsonContainerConfig.java:90:
addCommonEnvironmentVarsToAllContainers(configJson, host, port);
I thought that all containers configs are derived from the default
container config, so won't they just inherit the host and port?
Can you explain the case you notice the problem.

http://codereview.appspot.com/2000043/