You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@gluten.apache.org by "LuciferYang (via GitHub)" <gi...@apache.org> on 2026/07/17 08:14:10 UTC
[PR] [MINOR][VL][TEST] Drop dead Spark 3.2 TPC-H golden plans [gluten]
LuciferYang opened a new pull request, #12548:
URL: https://github.com/apache/gluten/pull/12548
### What changes were proposed in this pull request?
Follow-up to #12525 / #12541 / #12543. Now that Gluten no longer supports Spark 3.2, the TPC-H golden plans for Spark 3.2 are dead test fixtures.
- `backends-velox/.../VeloxTPCHSuite.scala`: drop the `case "32" => true` branch in `shouldCheckGoldenFiles`. `formatSparkVersion` is derived from `spark.version.substring(0, 2)` and can never be `"32"` on any supported profile (Spark 3.3+), so the branch is unreachable.
- `backends-velox/src/test/resources/tpch-approved-plan/{v1,v1-bhj,v1-ras,v1-bhj-ras}/spark32/`: remove all four `spark32/` subdirectories and their 84 golden `.txt` files. They were only loaded via `tpch-approved-plan/${subType()}/spark$formatSparkVersion/$id.txt` when the pruned branch matched.
The `spark33` / `spark34` / `spark35` case branches and golden plan directories are kept as-is. No behavior change on any supported Spark version.
### How was this patch tested?
- `./build/mvn -Pbackends-velox -Pspark-3.5 -pl backends-velox -am test-compile -DskipTests`: SUCCESS
- `./dev/format-scala-code.sh`: no additional diff
- Repo-wide `grep -r "tpch-approved-plan|spark32"` confirms `VeloxTPCHSuite.scala` is the only Scala/Java caller and the only remaining references to `spark32` outside this diff are catalogued for follow-up cleanup (`dev/*.sh`, `LICENSE`, `package/pom.xml`), which are intentionally out of scope for this test-infrastructure PR.
### Was this patch authored or co-authored using generative AI tooling?
Generated-by: Claude claude-opus-4-7
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [MINOR][VL][TEST] Drop dead Spark 3.2 TPC-H golden plans [gluten]
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on PR #12548:
URL: https://github.com/apache/gluten/pull/12548#issuecomment-5068578793
cc @jackylee-ch can we merge this one?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [MINOR][VL][TEST] Drop dead Spark 3.2 TPC-H golden plans [gluten]
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on PR #12548:
URL: https://github.com/apache/gluten/pull/12548#issuecomment-5000590524
cc @jackylee-ch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [MINOR][VL][TEST] Drop dead Spark 3.2 TPC-H golden plans [gluten]
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on PR #12548:
URL: https://github.com/apache/gluten/pull/12548#issuecomment-5086903688
Thank you @jackylee-ch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [MINOR][VL][TEST] Drop dead Spark 3.2 TPC-H golden plans [gluten]
Posted by "jackylee-ch (via GitHub)" <gi...@apache.org>.
jackylee-ch merged PR #12548:
URL: https://github.com/apache/gluten/pull/12548
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org