You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@qpid.apache.org by ac...@apache.org on 2012/07/11 17:26:36 UTC
svn commit: r1360228 - in /qpid/branches/0.18/qpid/cpp/src/qpid/ha:
Backup.cpp HaBroker.cpp
Author: aconway
Date: Wed Jul 11 15:26:36 2012
New Revision: 1360228
URL: http://svn.apache.org/viewvc?rev=1360228&view=rev
Log:
QPID-4128: HA should not use amq.failover for replication links
HA replication links should not use the amq.failover exchange to get updates
reconnect targets. amq.failover provides the client failover list, HA manages a
separate failover list for brokers. Replication links should be using the broker
list, and not allow it to be overwritten by amq.failover updates.
Review requested for 0.18, 2 line fix.
Modified:
qpid/branches/0.18/qpid/cpp/src/qpid/ha/Backup.cpp
qpid/branches/0.18/qpid/cpp/src/qpid/ha/HaBroker.cpp
Modified: qpid/branches/0.18/qpid/cpp/src/qpid/ha/Backup.cpp
URL: http://svn.apache.org/viewvc/qpid/branches/0.18/qpid/cpp/src/qpid/ha/Backup.cpp?rev=1360228&r1=1360227&r2=1360228&view=diff
==============================================================================
--- qpid/branches/0.18/qpid/cpp/src/qpid/ha/Backup.cpp (original)
+++ qpid/branches/0.18/qpid/cpp/src/qpid/ha/Backup.cpp Wed Jul 11 15:26:36 2012
@@ -82,7 +82,7 @@ void Backup::initialize(const Url& broke
url[0].host, url[0].port, protocol,
false, // durable
settings.mechanism, settings.username, settings.password,
- true); // amq.failover
+ false); // no amq.failover - don't want to use client URL.
{
sys::Mutex::ScopedLock l(lock);
link = result.first;
Modified: qpid/branches/0.18/qpid/cpp/src/qpid/ha/HaBroker.cpp
URL: http://svn.apache.org/viewvc/qpid/branches/0.18/qpid/cpp/src/qpid/ha/HaBroker.cpp?rev=1360228&r1=1360227&r2=1360228&view=diff
==============================================================================
--- qpid/branches/0.18/qpid/cpp/src/qpid/ha/HaBroker.cpp (original)
+++ qpid/branches/0.18/qpid/cpp/src/qpid/ha/HaBroker.cpp Wed Jul 11 15:26:36 2012
@@ -175,7 +175,8 @@ Manageable::status_t HaBroker::Managemen
broker::QPID_NAME_PREFIX + string("ha.link.") + uuid.str(),
url[0].host, url[0].port, protocol,
false, // durable
- settings.mechanism, settings.username, settings.password);
+ settings.mechanism, settings.username, settings.password,
+ false); // no amq.failover - don't want to use client URL.
boost::shared_ptr<broker::Link> link = result.first;
link->setUrl(url);
// Create a queue replicator
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@qpid.apache.org
For additional commands, e-mail: commits-help@qpid.apache.org