You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/01/25 02:32:04 UTC

[GitHub] [flink] zjureel opened a new pull request #18490: [FLINK-25794][sql-runtime] Clean cache after memory segments in it after they are released to MemoryManager

zjureel opened a new pull request #18490:
URL: https://github.com/apache/flink/pull/18490


   ## What is the purpose of the change
   
   This pr aims to clean cache in `LazyMemorySegmentPool` after memory segments in it are released to `MemoryManager`
   
   ## Verifying this change
   This change added tests and can be verified as follows:
     - *Added test `ResettableExternalBufferTest.testSegmentPoolCleanCache` that validates the cache is cleared in  `LazyMemorySegmentPool.cleanCache`
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (yes / no) no
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / no) no
     - The serializers: (yes / no / don't know) no
     - The runtime per-record code paths (performance sensitive): (yes / no / don't know) no
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / no / don't know) no
     - The S3 file system connector: (yes / no / don't know) no
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (yes / no) no
     - If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #18490: [FLINK-25794][sql-runtime] Clean cache after memory segments in it after they are released to MemoryManager

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18490:
URL: https://github.com/apache/flink/pull/18490#issuecomment-1020751414


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "0b17412ebe9b3b32233c36516fec6aed5865170d",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30097",
       "triggerID" : "0b17412ebe9b3b32233c36516fec6aed5865170d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4d6ae31377dfaf25e3a7a702b2ff54f00e099106",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30968",
       "triggerID" : "4d6ae31377dfaf25e3a7a702b2ff54f00e099106",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 0b17412ebe9b3b32233c36516fec6aed5865170d Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30097) 
   * 4d6ae31377dfaf25e3a7a702b2ff54f00e099106 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30968) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] zjureel commented on pull request #18490: [FLINK-25794][sql-runtime] Clean cache after memory segments in it after they are released to MemoryManager

Posted by GitBox <gi...@apache.org>.
zjureel commented on pull request #18490:
URL: https://github.com/apache/flink/pull/18490#issuecomment-1020930174


   Thanks @JingsongLi , I think I miss the operations in `MemoryManager` :(
   And another issue is in `BinaryHashTableTest.testBinaryHashBucketAreaNotEnoughMem`, there's no `table.free` after `table.close`, I think it should be and it causes memory leaks in my cache memory manager. What do you think?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #18490: [FLINK-25794][sql-runtime] Clean cache after memory segments in it after they are released to MemoryManager

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18490:
URL: https://github.com/apache/flink/pull/18490#issuecomment-1020751414


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "0b17412ebe9b3b32233c36516fec6aed5865170d",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30097",
       "triggerID" : "0b17412ebe9b3b32233c36516fec6aed5865170d",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 0b17412ebe9b3b32233c36516fec6aed5865170d Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30097) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #18490: [FLINK-25794][sql-runtime] Clean cache after memory segments in it after they are released to MemoryManager

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18490:
URL: https://github.com/apache/flink/pull/18490#issuecomment-1020751414


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "0b17412ebe9b3b32233c36516fec6aed5865170d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30097",
       "triggerID" : "0b17412ebe9b3b32233c36516fec6aed5865170d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4d6ae31377dfaf25e3a7a702b2ff54f00e099106",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30968",
       "triggerID" : "4d6ae31377dfaf25e3a7a702b2ff54f00e099106",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 4d6ae31377dfaf25e3a7a702b2ff54f00e099106 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30968) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #18490: [FLINK-25794][sql-runtime] Clean cache after memory segments in it after they are released to MemoryManager

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18490:
URL: https://github.com/apache/flink/pull/18490#issuecomment-1020751414






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] zjureel commented on pull request #18490: [FLINK-25794][sql-runtime] Clean cache after memory segments in it after they are released to MemoryManager

Posted by GitBox <gi...@apache.org>.
zjureel commented on pull request #18490:
URL: https://github.com/apache/flink/pull/18490#issuecomment-1020749306






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] JingsongLi commented on pull request #18490: [FLINK-25794][sql-runtime] Clean cache after memory segments in it after they are released to MemoryManager

Posted by GitBox <gi...@apache.org>.
JingsongLi commented on pull request #18490:
URL: https://github.com/apache/flink/pull/18490#issuecomment-1021804321


   > Thanks @JingsongLi , I think I miss the operations in `MemoryManager` :( And another issue is in `BinaryHashTableTest.testBinaryHashBucketAreaNotEnoughMem`, there's no `table.free` after `table.close`, I think it should be and it causes memory leaks in my cache memory manager. What do you think?
   
   I don't know, it seems that `area.freeMemory()` will release memory?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #18490: [FLINK-25794][sql-runtime] Clean cache after memory segments in it after they are released to MemoryManager

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #18490:
URL: https://github.com/apache/flink/pull/18490#issuecomment-1020751414


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "0b17412ebe9b3b32233c36516fec6aed5865170d",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "0b17412ebe9b3b32233c36516fec6aed5865170d",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 0b17412ebe9b3b32233c36516fec6aed5865170d UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] JingsongLi commented on pull request #18490: [FLINK-25794][sql-runtime] Clean cache after memory segments in it after they are released to MemoryManager

Posted by GitBox <gi...@apache.org>.
JingsongLi commented on pull request #18490:
URL: https://github.com/apache/flink/pull/18490#issuecomment-1020901998


   Hi @zjureel I replied you in JIRA.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #18490: [FLINK-25794][sql-runtime] Clean cache after memory segments in it after they are released to MemoryManager

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18490:
URL: https://github.com/apache/flink/pull/18490#issuecomment-1020751414


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "0b17412ebe9b3b32233c36516fec6aed5865170d",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30097",
       "triggerID" : "0b17412ebe9b3b32233c36516fec6aed5865170d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4d6ae31377dfaf25e3a7a702b2ff54f00e099106",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "4d6ae31377dfaf25e3a7a702b2ff54f00e099106",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 0b17412ebe9b3b32233c36516fec6aed5865170d Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30097) 
   * 4d6ae31377dfaf25e3a7a702b2ff54f00e099106 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] JingsongLi commented on pull request #18490: [FLINK-25794][sql-runtime] Clean cache after memory segments in it after they are released to MemoryManager

Posted by GitBox <gi...@apache.org>.
JingsongLi commented on pull request #18490:
URL: https://github.com/apache/flink/pull/18490#issuecomment-1020901998


   Hi @zjureel I replied you in JIRA.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] zjureel commented on pull request #18490: [FLINK-25794][sql-runtime] Clean cache after memory segments in it after they are released to MemoryManager

Posted by GitBox <gi...@apache.org>.
zjureel commented on pull request #18490:
URL: https://github.com/apache/flink/pull/18490#issuecomment-1020749306


   Hello @KarmaGYZ @JingsongLi , could you help to review this issue when you're free?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #18490: [FLINK-25794][sql-runtime] Clean cache after memory segments in it after they are released to MemoryManager

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #18490:
URL: https://github.com/apache/flink/pull/18490#issuecomment-1020750446






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #18490: [FLINK-25794][sql-runtime] Clean cache after memory segments in it after they are released to MemoryManager

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18490:
URL: https://github.com/apache/flink/pull/18490#issuecomment-1020751414


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "0b17412ebe9b3b32233c36516fec6aed5865170d",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30097",
       "triggerID" : "0b17412ebe9b3b32233c36516fec6aed5865170d",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 0b17412ebe9b3b32233c36516fec6aed5865170d Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30097) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #18490: [FLINK-25794][sql-runtime] Clean cache after memory segments in it after they are released to MemoryManager

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #18490:
URL: https://github.com/apache/flink/pull/18490#issuecomment-1020750446


   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit 0b17412ebe9b3b32233c36516fec6aed5865170d (Tue Jan 25 02:35:41 UTC 2022)
   
   **Warnings:**
    * No documentation files were touched! Remember to keep the Flink docs up to date!
    * **This pull request references an unassigned [Jira ticket](https://issues.apache.org/jira/browse/FLINK-25794).** According to the [code contribution guide](https://flink.apache.org/contributing/contribute-code.html), tickets need to be assigned before starting with the implementation work.
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] zjureel edited a comment on pull request #18490: [FLINK-25794][sql-runtime] Clean cache after memory segments in it after they are released to MemoryManager

Posted by GitBox <gi...@apache.org>.
zjureel edited a comment on pull request #18490:
URL: https://github.com/apache/flink/pull/18490#issuecomment-1033300250


   > 
   
   No, the 'area.freeMemory' will call `LazyMemorySegmentPool.returnPage` and return the allocated `MemorySegment` to `LazyMemorySegmentPool.cachePages` only, won't free them to `MemoryManager`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] zjureel commented on pull request #18490: [FLINK-25794][sql-runtime] Clean cache after memory segments in it after they are released to MemoryManager

Posted by GitBox <gi...@apache.org>.
zjureel commented on pull request #18490:
URL: https://github.com/apache/flink/pull/18490#issuecomment-1033300250


   > 
   
   No, the 'area.freeMemory' will call `LazyMemorySegmentPool.returnPage` and return the allocated `MemorySegment` to `LazyMemorySegmentPool.cachePages` only and won't free them to `MemoryManager`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org