[GitHub] [spark] maropu commented on a change in pull request #30108: [SPARK-33197][SQL] Make changes to spark.sql.analyzer.maxIterations take effect at runtime

[GitBox <gi...@apache.org>]

maropu commented on a change in pull request #30108:
URL: https://github.com/apache/spark/pull/30108#discussion_r509262011



##########
File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/AnalysisSuite.scala
##########
@@ -782,10 +783,26 @@ class AnalysisSuite extends AnalysisTest with Matchers {
       $"a" / $"d" as "div4",
       $"e" / $"e" as "div5")
 
-    val message = intercept[TreeNodeException[LogicalPlan]] {
+    val message1 = intercept[TreeNodeException[LogicalPlan]] {
       testAnalyzer.execute(plan)
     }.getMessage
-    assert(message.startsWith(s"Max iterations ($maxIterations) reached for batch Resolution, " +
+    assert(message1.startsWith(s"Max iterations ($maxIterations) reached for batch Resolution, " +
+      s"please set '${SQLConf.ANALYZER_MAX_ITERATIONS.key}' to a larger value."))
+
+    conf.setConfString(SQLConf.ANALYZER_MAX_ITERATIONS.key, maxIterationsEnough.toString)

Review comment:
       Could you add a new test unit with the prefix `test("SPARK-33197 ...` instead of modifying the existing test?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org