[jira] [Commented] (OFBIZ-5842) Implement JUnit tests for Entity Query Builder

["Adrian Crum (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OFBIZ-5842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14188258#comment-14188258 ] 

Adrian Crum commented on OFBIZ-5842:
------------------------------------

If the assertEquals method is testing for equality, then the text should say so. Instead of:

assertEquals("queryCount(): Total Number of Records does not match", totalRecordsByEntityEngine.size(), numberOfRecordsByEntityQuery);

you should have:

assertEquals("queryCount(): Total Number of Records match", totalRecordsByEntityEngine.size(), numberOfRecordsByEntityQuery);

In other words, the text in your patch is backwards.

> Implement JUnit tests for Entity Query Builder
> ----------------------------------------------
>
>                 Key: OFBIZ-5842
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-5842
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: Trunk
>            Reporter: Arun Patidar
>            Assignee: Ashish Vijaywargiya
>            Priority: Minor
>         Attachments: OFBIZ-5842.patch
>
>
> As we have Entity Query Builder implemented in trunk (OFBIZ-4053) and now we should add Junit tests for its methods.
> As per initial analyses, we can write Junit tests for following methods of Entity Query Builder:
> 1. queryList()
> 2. queryFirst()
> 3. queryCount()
> 4. queryOne()
> 5. distinct()
> 6. filterByDate()
> 7. orderBy()
> 8. select()
> 9. cursorForwardOnly()
> 10. cursorScrollSensitive()
> 11. cursorScrollInSensitive()
> 12. fetchSize()
> 13. maxRows()
> 14. cache()
> 15. queryIterator()



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)