You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@parquet.apache.org by GitBox <gi...@apache.org> on 2021/02/23 21:27:41 UTC
[GitHub] [parquet-mr] dongjoon-hyun opened a new pull request #874: PARQUET-1988: Upgrade to ZSTD 1.4.8-5
dongjoon-hyun opened a new pull request #874:
URL: https://github.com/apache/parquet-mr/pull/874
Make sure you have checked _all_ steps below.
### Jira
- [ ] My PR addresses the following [Parquet Jira](https://issues.apache.org/jira/browse/PARQUET/) issues and references them in the PR title. For example, "PARQUET-1234: My Parquet PR"
- https://issues.apache.org/jira/browse/PARQUET-XXX
- In case you are adding a dependency, check if the license complies with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
### Tests
- [ ] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
### Commits
- [ ] My commits all reference Jira issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [ ] In case of new functionality, my PR adds documentation that describes how to use it.
- All the public functions and the classes in the PR contain Javadoc that explain what it does
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [parquet-mr] dongjoon-hyun commented on pull request #874: PARQUET-1988: Upgrade to ZSTD 1.4.8-5
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #874:
URL: https://github.com/apache/parquet-mr/pull/874#issuecomment-784572075
Sorry, I missed this API incompatibility. I switched this PR to draft.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [parquet-mr] dongjoon-hyun commented on pull request #874: PARQUET-1988: Upgrade to ZSTD 1.4.8-6
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #874:
URL: https://github.com/apache/parquet-mr/pull/874#issuecomment-787398858
Thank you, @wangyum .
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [parquet-mr] Fokko merged pull request #874: PARQUET-1988: Upgrade to ZSTD 1.4.8-6
Posted by GitBox <gi...@apache.org>.
Fokko merged pull request #874:
URL: https://github.com/apache/parquet-mr/pull/874
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [parquet-mr] dongjoon-hyun commented on pull request #874: PARQUET-1988: Upgrade to ZSTD 1.4.8-5
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #874:
URL: https://github.com/apache/parquet-mr/pull/874#issuecomment-784542778
It's rebased and force-pushed. Let's see.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [parquet-mr] Fokko commented on pull request #874: PARQUET-1988: Upgrade to ZSTD 1.4.8-6
Posted by GitBox <gi...@apache.org>.
Fokko commented on pull request #874:
URL: https://github.com/apache/parquet-mr/pull/874#issuecomment-787413335
Thanks @dongjoon-hyun Looking good!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [parquet-mr] dongjoon-hyun commented on pull request #874: PARQUET-1988: Upgrade to ZSTD 1.4.8-5
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #874:
URL: https://github.com/apache/parquet-mr/pull/874#issuecomment-784537975
Hi, @gszadovszky .
This is an update to be complete in `Buffer Pool` feature.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [parquet-mr] dongjoon-hyun commented on pull request #874: PARQUET-1988: Upgrade to ZSTD 1.4.8-6
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #874:
URL: https://github.com/apache/parquet-mr/pull/874#issuecomment-787509166
Thank you, @Fokko !
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [parquet-mr] dongjoon-hyun closed pull request #874: PARQUET-1988: Upgrade to ZSTD 1.4.8-5
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun closed pull request #874:
URL: https://github.com/apache/parquet-mr/pull/874
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [parquet-mr] dongjoon-hyun commented on pull request #874: PARQUET-1988: Upgrade to ZSTD 1.4.8-6
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #874:
URL: https://github.com/apache/parquet-mr/pull/874#issuecomment-787047244
Could you review this again please, @Fokko and @gszadovszky ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [parquet-mr] dongjoon-hyun commented on pull request #874: PARQUET-1988: Upgrade to ZSTD 1.4.8-5
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #874:
URL: https://github.com/apache/parquet-mr/pull/874#issuecomment-784542285
Thank you for review and approval, @Fokko .
I didn't expect the UT failure here. Let me update my branch to the `master` branch once more.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org