You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "jscheffl (via GitHub)" <gi...@apache.org> on 2025/03/26 22:28:50 UTC

[PR] Add linter check for legacy unlimited parallelism [airflow]

jscheffl opened a new pull request, #48423:
URL: https://github.com/apache/airflow/pull/48423

   Alongside with #48218 this PR adds a config linter message for legacy unlimited paraellism.
   
   Merge only after #48218


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Add linter check for legacy unlimited parallelism [airflow]

Posted by "jscheffl (via GitHub)" <gi...@apache.org>.
jscheffl commented on code in PR #48423:
URL: https://github.com/apache/airflow/pull/48423#discussion_r2017640677


##########
airflow-core/src/airflow/cli/commands/config_command.py:
##########
@@ -88,6 +88,7 @@ class ConfigChange:
     :param renamed_to: The new section and option if the configuration is renamed.
     :param was_deprecated: If the config is removed, whether the old config was deprecated.
     :param was_removed: If the config is removed.
+    :param is_invalid_if: If the current config value is invalid in the future.

Review Comment:
   Yeah I also thought about a callback or `lambda:`... but then considered I don't want to over-engineer.
   
   If there are more use cases and different requirements, feel free to extend in a follow-up PR.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Add linter check for legacy unlimited parallelism [airflow]

Posted by "Lee-W (via GitHub)" <gi...@apache.org>.
Lee-W commented on code in PR #48423:
URL: https://github.com/apache/airflow/pull/48423#discussion_r2015407165


##########
airflow-core/src/airflow/cli/commands/config_command.py:
##########
@@ -88,6 +88,7 @@ class ConfigChange:
     :param renamed_to: The new section and option if the configuration is renamed.
     :param was_deprecated: If the config is removed, whether the old config was deprecated.
     :param was_removed: If the config is removed.
+    :param is_invalid_if: If the current config value is invalid in the future.

Review Comment:
   We probably could make it a callback and that it do customized value checking? I believe @jedcunningham and @sunank200 introduced a change that need this functionality. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Add linter check for legacy unlimited parallelism [airflow]

Posted by "jscheffl (via GitHub)" <gi...@apache.org>.
jscheffl merged PR #48423:
URL: https://github.com/apache/airflow/pull/48423


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org