You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/06/14 07:37:26 UTC

[GitHub] [skywalking] wu-sheng opened a new issue #7112: Add debug services(GraphQL) in query protocol

wu-sheng opened a new issue #7112:
URL: https://github.com/apache/skywalking/issues/7112


   @kezhenxu94 @hanahmily We have been suffering the runtime debugging issues in the prod env for months. I want to discuss whether we should consider adding a new type of GraphQL service, named `debug`.
   
   `debug` catalog should be a group of interactive services, provided from OAP instance level. Because of this, no query should be done through UI webapp or load balancer.
   
   A demo command of debug service should like this(Ignore the format, I don't write it in GraphQL grammar)
   > debug start --target als-k8s --duration 5m
   > debug statistic 
   > debug clear
   
   We should work on a statistic API, very similar to the internal observability APIs, but because it only works after receiving the `start` command with a certain duration. Then, we could get the result as a statistic table until 
   1. The next `debug start`
   2. `debug clear`
   3. 20min(or another threshold value) passed.
   
   FYI @apache/skywalking-committers You may notice we could use this in the agent trace/meter/log analysis statistic. 
   
   The major difference between `debug` API and `telemetry` APIs is not from a tech perspective, it is more from a usage scenario. The `debug` API implementation could be more aggressive and provide more context in on-demand debugging.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] kezhenxu94 commented on issue #7112: Add debug services(GraphQL) in query protocol

Posted by GitBox <gi...@apache.org>.

kezhenxu94 commented on issue #7112:
URL: https://github.com/apache/skywalking/issues/7112#issuecomment-859611227






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] hanahmily commented on issue #7112: Add debug services(GraphQL) in query protocol

Posted by GitBox <gi...@apache.org>.

hanahmily commented on issue #7112:
URL: https://github.com/apache/skywalking/issues/7112#issuecomment-859955784


   @wu-sheng and I discussed this solution a few weeks ago. After that, an auto-config log4j gives more help than dynamic statistics. . We should promise to change the logging level on the fly since rebooting OAP would cover up the problems.
   
   The reason is :
   
   1. Logging has more details than metrics, which will give our users more flexible paths to investigate issues. 
   2. Logging would use fewer resources than specific metrics with some turn-on/off switches. 
   
   For this issue, if the ALS-related debugs logging is active, the user will leverage `grep` and `wc` to filter and statistic objects they want. We might provide some instruments about how to statistic the key metrics, or enhancement `swctl` to handle logs. 
   
   Future more, log4j has provided some ways to implement [auto-config](https://logging.apache.org/log4j/2.x/manual/customconfig.html). We will not have to introduce any new APIs. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] wu-sheng commented on issue #7112: Add debug services(GraphQL) in query protocol

Posted by GitBox <gi...@apache.org>.

wu-sheng commented on issue #7112:
URL: https://github.com/apache/skywalking/issues/7112#issuecomment-859618882






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] hanahmily edited a comment on issue #7112: Add debug services(GraphQL) in query protocol

Posted by GitBox <gi...@apache.org>.

hanahmily edited a comment on issue #7112:
URL: https://github.com/apache/skywalking/issues/7112#issuecomment-859955784






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] wu-sheng closed issue #7112: Add debug services(GraphQL) in query protocol

Posted by GitBox <gi...@apache.org>.

wu-sheng closed issue #7112:
URL: https://github.com/apache/skywalking/issues/7112


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org