You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Dan Burkert (Code Review)" <ge...@cloudera.org> on 2017/10/30 17:50:41 UTC
[kudu-CR] Update auth token validity seconds description
Hello Alexey Serbin,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/8413
to review the following change.
Change subject: Update auth_token_validity_seconds description
......................................................................
Update auth_token_validity_seconds description
The caveats are no longer relevant since KUDU-2013 landed.
Change-Id: I050e39d0377049cdaac0afb5085a8a9a19d620a5
---
M src/kudu/master/master.cc
1 file changed, 2 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/13/8413/1
--
To view, visit http://gerrit.cloudera.org:8080/8413
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I050e39d0377049cdaac0afb5085a8a9a19d620a5
Gerrit-Change-Number: 8413
Gerrit-PatchSet: 1
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
[kudu-CR] Update auth token validity seconds description
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/8413 )
Change subject: Update auth_token_validity_seconds description
......................................................................
Patch Set 1:
(1 comment)
Thank you for taking care of this. I think using 're-acquire' instead of 'renew' would be better.
http://gerrit.cloudera.org:8080/#/c/8413/1/src/kudu/master/master.cc
File src/kudu/master/master.cc:
http://gerrit.cloudera.org:8080/#/c/8413/1/src/kudu/master/master.cc@78
PS1, Line 78: renew
nit: maybe, it's better to have 're-acquire' here instead of 'renew'? Kudu clients are required to present 'primary' credentials to get a completely new ticket.
As I understand, Kudu tokens are not renewable in the sense as Kerberos tickets are, so 're-acquire' might be a better choice here to steer away from possible confusion.
--
To view, visit http://gerrit.cloudera.org:8080/8413
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I050e39d0377049cdaac0afb5085a8a9a19d620a5
Gerrit-Change-Number: 8413
Gerrit-PatchSet: 1
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Tue, 31 Oct 2017 06:34:12 +0000
Gerrit-HasComments: Yes
[kudu-CR] Update auth token validity seconds description
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8413 )
Change subject: Update auth_token_validity_seconds description
......................................................................
Update auth_token_validity_seconds description
The caveats are no longer relevant since KUDU-2013 landed.
Change-Id: I050e39d0377049cdaac0afb5085a8a9a19d620a5
Reviewed-on: http://gerrit.cloudera.org:8080/8413
Tested-by: Kudu Jenkins
Reviewed-by: Alexey Serbin <as...@cloudera.com>
---
M src/kudu/master/master.cc
1 file changed, 2 insertions(+), 3 deletions(-)
Approvals:
Kudu Jenkins: Verified
Alexey Serbin: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/8413
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I050e39d0377049cdaac0afb5085a8a9a19d620a5
Gerrit-Change-Number: 8413
Gerrit-PatchSet: 3
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] Update auth token validity seconds description
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/8413
to look at the new patch set (#2).
Change subject: Update auth_token_validity_seconds description
......................................................................
Update auth_token_validity_seconds description
The caveats are no longer relevant since KUDU-2013 landed.
Change-Id: I050e39d0377049cdaac0afb5085a8a9a19d620a5
---
M src/kudu/master/master.cc
1 file changed, 2 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/13/8413/2
--
To view, visit http://gerrit.cloudera.org:8080/8413
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I050e39d0377049cdaac0afb5085a8a9a19d620a5
Gerrit-Change-Number: 8413
Gerrit-PatchSet: 2
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] Update auth token validity seconds description
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/8413 )
Change subject: Update auth_token_validity_seconds description
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/8413
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I050e39d0377049cdaac0afb5085a8a9a19d620a5
Gerrit-Change-Number: 8413
Gerrit-PatchSet: 2
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Tue, 31 Oct 2017 16:02:50 +0000
Gerrit-HasComments: No
[kudu-CR] Update auth token validity seconds description
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/8413 )
Change subject: Update auth_token_validity_seconds description
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/8413/1/src/kudu/master/master.cc
File src/kudu/master/master.cc:
http://gerrit.cloudera.org:8080/#/c/8413/1/src/kudu/master/master.cc@78
PS1, Line 78: reacq
> nit: maybe, it's better to have 're-acquire' here instead of 'renew'? Kudu
Good point.
--
To view, visit http://gerrit.cloudera.org:8080/8413
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I050e39d0377049cdaac0afb5085a8a9a19d620a5
Gerrit-Change-Number: 8413
Gerrit-PatchSet: 2
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Tue, 31 Oct 2017 14:18:08 +0000
Gerrit-HasComments: Yes