You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2017/12/11 05:14:26 UTC

[GitHub] massakam commented on a change in pull request #949: Fix authentication logic in WebSocketWebResource

massakam commented on a change in pull request #949: Fix authentication logic in WebSocketWebResource
URL: https://github.com/apache/incubator-pulsar/pull/949#discussion_r155985362
 
 

 ##########
 File path: pulsar-websocket/src/main/java/org/apache/pulsar/websocket/admin/WebSocketWebResource.java
 ##########
 @@ -62,14 +64,15 @@ protected WebSocketService service() {
      * @return the web service caller identification
      */
     public String clientAppId() {
-        if (clientId != null && service().getConfig().isAuthenticationEnabled()) {
+        if (isBlank(clientId) && service().getConfig().isAuthenticationEnabled()) {
 
 Review comment:
   I have modified `WebSocketWebResource#clientAppId()` to try acquiring `clientId` even when authentication is disabled. Is my understanding correct?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services