You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by tbouron <gi...@git.apache.org> on 2017/04/14 12:26:43 UTC
[GitHub] brooklyn-server pull request #637: Remove deprecated REST API endpoints
GitHub user tbouron opened a pull request:
https://github.com/apache/brooklyn-server/pull/637
Remove deprecated REST API endpoints
This removes the deprecated REST API endpoints from Brooklyn 0.7.0. It also fixes the launcher configuration (as the `VersionApi` has been entirely removed) and unit tests.
Please note that I didn't touch the `LocationApi` for a very specific reason: currently, this is the only of getting the locations defined within `brooklyn.properties`/`brooklyn.cfg` files. We need to figure out first how to handle those locations before removing the endpoints. As you can see, this is not in the scope of this PR.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tbouron/brooklyn-server update/deprecated-apis
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/brooklyn-server/pull/637.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #637
----
commit e47107e2833ce12286e5a4b7e014121e467629c7
Author: Thomas Bouron <th...@cloudsoftcorp.com>
Date: 2017-04-14T08:07:40Z
Remove deprecated APIs
commit e36ef90f6d18a3d8d25faf587fccfd7dd7ac31a0
Author: Thomas Bouron <th...@cloudsoftcorp.com>
Date: 2017-04-14T12:21:34Z
Fix unit tests and launcher config
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-server pull request #637: Remove deprecated REST API endpoints
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/brooklyn-server/pull/637
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-server issue #637: Remove deprecated REST API endpoints
Posted by geomacy <gi...@git.apache.org>.
Github user geomacy commented on the issue:
https://github.com/apache/brooklyn-server/pull/637
\U0001f44d lgtm; have also tested a variety of `br` command line operations against this without problems. Will merge.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-server issue #637: Remove deprecated REST API endpoints
Posted by tbouron <gi...@git.apache.org>.
Github user tbouron commented on the issue:
https://github.com/apache/brooklyn-server/pull/637
BTW, I also checked the JSGUI and it does not use any of the deprecated call so you are good on this part
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-server issue #637: Remove deprecated REST API endpoints
Posted by geomacy <gi...@git.apache.org>.
Github user geomacy commented on the issue:
https://github.com/apache/brooklyn-server/pull/637
@tbouron that's done thanks
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-server issue #637: Remove deprecated REST API endpoints
Posted by tbouron <gi...@git.apache.org>.
Github user tbouron commented on the issue:
https://github.com/apache/brooklyn-server/pull/637
Awesome, thanks @geomacy! Could you also take a look at https://github.com/apache/brooklyn-client/issues/45 please? That will avoid the build to fail
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---