You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sentry.apache.org by Alexander Kolbasov <ak...@gmail.com> on 2017/07/12 15:59:22 UTC
Review Request 60806: SENTRY-1696 Expose time spent creating the
initial snapshot as a metric
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60806/
-----------------------------------------------------------
Review request for sentry, Brian Towles, kalyan kumar kalvagadda, Na Li, Sergio Pena, and Vamsee Yarlagadda.
Bugs: SENTRY-1696
https://issues.apache.org/jira/browse/SENTRY-1696
Repository: sentry
Description
-------
SENTRY-1696 Expose time spent creating the initial snapshot as a metric
Diffs
-----
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/FullUpdateInitializer.java 1490581cc9bb882f4c14a180ade43aa4e8c18a82
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java 2d581f73eb8734d60f2b666b8d4ebed7a7827005
Diff: https://reviews.apache.org/r/60806/diff/1/
Testing
-------
Thanks,
Alexander Kolbasov
Re: Review Request 60806: SENTRY-1696 Expose time spent creating the
initial snapshot as a metric
Posted by Alexander Kolbasov <ak...@gmail.com>.
> On July 12, 2017, 4:31 p.m., Vamsee Yarlagadda wrote:
> > Ship It!
Thanks for the quick review!
- Alexander
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60806/#review180313
-----------------------------------------------------------
On July 12, 2017, 3:59 p.m., Alexander Kolbasov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60806/
> -----------------------------------------------------------
>
> (Updated July 12, 2017, 3:59 p.m.)
>
>
> Review request for sentry, Brian Towles, kalyan kumar kalvagadda, Na Li, Sergio Pena, and Vamsee Yarlagadda.
>
>
> Bugs: SENTRY-1696
> https://issues.apache.org/jira/browse/SENTRY-1696
>
>
> Repository: sentry
>
>
> Description
> -------
>
> SENTRY-1696 Expose time spent creating the initial snapshot as a metric
>
>
> Diffs
> -----
>
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/FullUpdateInitializer.java 1490581cc9bb882f4c14a180ade43aa4e8c18a82
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java 2d581f73eb8734d60f2b666b8d4ebed7a7827005
>
>
> Diff: https://reviews.apache.org/r/60806/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Alexander Kolbasov
>
>
Re: Review Request 60806: SENTRY-1696 Expose time spent creating the
initial snapshot as a metric
Posted by Vamsee Yarlagadda <va...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60806/#review180313
-----------------------------------------------------------
Ship it!
Ship It!
- Vamsee Yarlagadda
On July 12, 2017, 3:59 p.m., Alexander Kolbasov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60806/
> -----------------------------------------------------------
>
> (Updated July 12, 2017, 3:59 p.m.)
>
>
> Review request for sentry, Brian Towles, kalyan kumar kalvagadda, Na Li, Sergio Pena, and Vamsee Yarlagadda.
>
>
> Bugs: SENTRY-1696
> https://issues.apache.org/jira/browse/SENTRY-1696
>
>
> Repository: sentry
>
>
> Description
> -------
>
> SENTRY-1696 Expose time spent creating the initial snapshot as a metric
>
>
> Diffs
> -----
>
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/FullUpdateInitializer.java 1490581cc9bb882f4c14a180ade43aa4e8c18a82
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java 2d581f73eb8734d60f2b666b8d4ebed7a7827005
>
>
> Diff: https://reviews.apache.org/r/60806/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Alexander Kolbasov
>
>
Re: Review Request 60806: SENTRY-1696 Expose time spent creating the
initial snapshot as a metric
Posted by Alexander Kolbasov <ak...@gmail.com>.
> On July 12, 2017, 8:29 p.m., Na Li wrote:
> > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java
> > Lines 87 (patched)
> > <https://reviews.apache.org/r/60806/diff/1/?file=1774872#file1774872line87>
> >
> > can you move the measurement to FullUpdateInitializer class? So it can be measured regardless the caller.
> >
> > In sentry-1769, the caller will not be HMSFollower. and your change will not be useful.
This is integrated using the code that existed. It is up to SENTRY-1769 to make sure everythign still works correctly. Please verify this with SENTRY-1769 review.
- Alexander
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60806/#review180351
-----------------------------------------------------------
On July 12, 2017, 3:59 p.m., Alexander Kolbasov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60806/
> -----------------------------------------------------------
>
> (Updated July 12, 2017, 3:59 p.m.)
>
>
> Review request for sentry, Brian Towles, kalyan kumar kalvagadda, Na Li, Sergio Pena, and Vamsee Yarlagadda.
>
>
> Bugs: SENTRY-1696
> https://issues.apache.org/jira/browse/SENTRY-1696
>
>
> Repository: sentry
>
>
> Description
> -------
>
> SENTRY-1696 Expose time spent creating the initial snapshot as a metric
>
>
> Diffs
> -----
>
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/FullUpdateInitializer.java 1490581cc9bb882f4c14a180ade43aa4e8c18a82
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java 2d581f73eb8734d60f2b666b8d4ebed7a7827005
>
>
> Diff: https://reviews.apache.org/r/60806/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Alexander Kolbasov
>
>
Re: Review Request 60806: SENTRY-1696 Expose time spent creating the
initial snapshot as a metric
Posted by Na Li <li...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60806/#review180351
-----------------------------------------------------------
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java
Lines 87 (patched)
<https://reviews.apache.org/r/60806/#comment255488>
can you move the measurement to FullUpdateInitializer class? So it can be measured regardless the caller.
In sentry-1769, the caller will not be HMSFollower. and your change will not be useful.
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java
Lines 87 (patched)
<https://reviews.apache.org/r/60806/#comment255489>
can you move the measurement to FullUpdateInitializer class? So it can be measured regardless the caller.
In sentry-1769, the caller will not be HMSFollower. and your change will not be useful.
- Na Li
On July 12, 2017, 3:59 p.m., Alexander Kolbasov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60806/
> -----------------------------------------------------------
>
> (Updated July 12, 2017, 3:59 p.m.)
>
>
> Review request for sentry, Brian Towles, kalyan kumar kalvagadda, Na Li, Sergio Pena, and Vamsee Yarlagadda.
>
>
> Bugs: SENTRY-1696
> https://issues.apache.org/jira/browse/SENTRY-1696
>
>
> Repository: sentry
>
>
> Description
> -------
>
> SENTRY-1696 Expose time spent creating the initial snapshot as a metric
>
>
> Diffs
> -----
>
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/FullUpdateInitializer.java 1490581cc9bb882f4c14a180ade43aa4e8c18a82
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java 2d581f73eb8734d60f2b666b8d4ebed7a7827005
>
>
> Diff: https://reviews.apache.org/r/60806/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Alexander Kolbasov
>
>