You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kvrocks.apache.org by "git-hulk (via GitHub)" <gi...@apache.org> on 2023/06/22 12:55:05 UTC
[GitHub] [kvrocks-website] git-hulk opened a new pull request, #113: Fix the download links after graduation
git-hulk opened a new pull request, #113:
URL: https://github.com/apache/kvrocks-website/pull/113
As the title mentioned, we move the resource after graduation, so need to fix the old download links.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kvrocks-website] git-hulk commented on pull request #113: Fix the download links after graduation
Posted by "git-hulk (via GitHub)" <gi...@apache.org>.
git-hulk commented on PR #113:
URL: https://github.com/apache/kvrocks-website/pull/113#issuecomment-1602677292
> @git-hulk This means the `2.5.0` release will be without the `incubating` suffix, right?
Yes, exactly. We don’t need to bring the incubator prefix after graduation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kvrocks-website] tisonkun commented on pull request #113: Fix the download links after graduation
Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun commented on PR #113:
URL: https://github.com/apache/kvrocks-website/pull/113#issuecomment-1602689789
I'm pushing a follow-up on this one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kvrocks-website] torwig commented on pull request #113: Fix the download links after graduation
Posted by "torwig (via GitHub)" <gi...@apache.org>.
torwig commented on PR #113:
URL: https://github.com/apache/kvrocks-website/pull/113#issuecomment-1602622463
@git-hulk This means the `2.5.0` release will be without the `incubating` suffix, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kvrocks-website] tisonkun commented on a diff in pull request #113: Fix the download links after graduation
Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun commented on code in PR #113:
URL: https://github.com/apache/kvrocks-website/pull/113#discussion_r1238571028
##########
src/components/Releases/index.tsx:
##########
@@ -14,9 +14,13 @@ type ReleaseData = {
signature: string,
}
-function createReleaseData(version: string): ReleaseData {
- const vtag = `${version}-incubating`
- const archive = `https://downloads.apache.org/incubator/kvrocks/${version}/apache-kvrocks-${vtag}-src.tar.gz`
+function createReleaseData(index: number, version: string): ReleaseData {
+ var vtag = `${version}-incubating`
+ // Drop the incubating suffix for releases after graduation
+ if (index >= 4) {
+ vtag = `${version}`
+ }
Review Comment:
Why not inline the version to the `versions` list so that we don't do if-else here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kvrocks-website] tisonkun merged pull request #113: Fix the download links after graduation
Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun merged PR #113:
URL: https://github.com/apache/kvrocks-website/pull/113
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org