[jira] [Commented] (HBASE-14307) Incorrect use of positional read api in HFileBlock

["ramkrishna.s.vasudevan (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-14307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14712549#comment-14712549 ] 

ramkrishna.s.vasudevan commented on HBASE-14307:
------------------------------------------------

[~srevanka]
Can you explain a bit more here?  In the normal case we are treating that what ever we read will atleast of what 'size' needs because we are sure that the thing that we require is in that block.  That is why we don't want to iterate for the next block's header size (the val represented by 'extraSize' ) and we are ok if we are not able to read that extraSize.
Coming to the chunked-encoding, are you facing some issue with this API using HBase?  Ideally the size that hbase specifies should be the encoded size only- do you see otherwise? I have not worked with this chunked encoding type FS.  Lets see what others have to say here.

> Incorrect use of positional read api in HFileBlock
> --------------------------------------------------
>
>                 Key: HBASE-14307
>                 URL: https://issues.apache.org/jira/browse/HBASE-14307
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Shradha Revankar
>            Priority: Minor
>
> Considering that {{read()}} is not guaranteed to read all bytes, 
> I'm interested to understand this particular piece of code and why is partial read treated as an error :
> https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileBlock.java#L1446-L1450
> Particularly, if hbase were to use a different filesystem, say WebhdfsFileSystem, this would not work, please also see https://issues.apache.org/jira/browse/HDFS-8943 for discussion around this.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)