You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@roller.apache.org by GitBox <gi...@apache.org> on 2021/08/08 21:49:43 UTC

[GitHub] [roller] mbien commented on pull request #96: Deprections, compiler warning fixes, local refactorings and JDK 17 support

mbien commented on pull request #96:
URL: https://github.com/apache/roller/pull/96#issuecomment-894860204


   > Works for me. I built and ran on JDK17 and did not notice any problems.
   > 
   > I did notice one error in tests but I think it is fixed in master:
   > 
   > ```
   > [ERROR] Errors:
   > [ERROR]   SingleThreadedFeedUpdaterTest.testUpdateSubscription:72 » Updater Error fetchi...
   > ```
   
   hmm. This test usually fails when rollerblogger.org is temporary unreachable since it relies on its feed.
   
   I tested this PR again and everything was green except the IPBanListTest, but the test itself has some file-io race conditions on my system - but this would be unrelated to this PR. Going to integrate this but keep an eye on the test :)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@roller.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org