[jira] [Commented] (ORC-248) The new padStream method can throw a NegativeArraySizeException.

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ORC-248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16459872#comment-16459872 ] 

ASF GitHub Bot commented on ORC-248:
------------------------------------

Github user t3rmin4t0r commented on a diff in the pull request:

    https://github.com/apache/orc/pull/259#discussion_r185275471
  
    --- Diff: java/core/src/java/org/apache/orc/OrcConf.java ---
    @@ -152,7 +152,9 @@
       OVERWRITE_OUTPUT_FILE("orc.overwrite.output.file", "orc.overwrite.output.file", false,
         "A boolean flag to enable overwriting of the output file if it already exists.\n"),
       IS_SCHEMA_EVOLUTION_CASE_SENSITIVE("orc.schema.evolution.case.sensitive", "orc.schema.evolution.case.sensitive", true,
    -          "A boolean flag to determine if the comparision of field names in schema evolution is case sensitive .\n")
    +          "A boolean flag to determine if the comparision of field names in schema evolution is case sensitive .\n"),
    +  WRITE_SHORTENED_BLOCKS("orc.write.shortened.blocks", null, false,
    --- End diff --
    
    Might as well call it what it is "orc.write.variable.length.blocks"


> The new padStream method can throw a NegativeArraySizeException.
> ----------------------------------------------------------------
>
>                 Key: ORC-248
>                 URL: https://issues.apache.org/jira/browse/ORC-248
>             Project: ORC
>          Issue Type: Bug
>            Reporter: Owen O'Malley
>            Assignee: Owen O'Malley
>            Priority: Blocker
>             Fix For: 1.5.0
>
>
> {code:java}
> Exception in thread "main" java.lang.NegativeArraySizeException
>         at org.apache.orc.impl.HadoopShimsPre2_3.padStream(HadoopShimsPre2_3.java:51)
>         at org.apache.orc.impl.HadoopShimsCurrent.padStreamToBlock(HadoopShimsCurrent.java:52)
>         at org.apache.orc.impl.PhysicalFsWriter.padStripe(PhysicalFsWriter.java:140)
>         at org.apache.orc.impl.PhysicalFsWriter.finalizeStripe(PhysicalFsWriter.java:341)
>         at org.apache.orc.impl.WriterImpl.flushStripe(WriterImpl.java:438)
>         at org.apache.orc.impl.WriterImpl.checkMemory(WriterImpl.java:262)
>         at org.apache.orc.impl.MemoryManagerImpl.notifyWriters(MemoryManagerImpl.java:190)
>         at org.apache.orc.impl.MemoryManagerImpl.addedRow(MemoryManagerImpl.java:178)
>         at org.apache.orc.impl.WriterImpl.addRowBatch(WriterImpl.java:539)
>         at org.apache.orc.bench.convert.orc.OrcWriter.writeBatch(OrcWriter.java:48)
>         at org.apache.orc.bench.convert.GenerateVariants.main(GenerateVariants.java:211)
>         at org.apache.orc.bench.Driver.main(Driver.java:62)
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)