You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@trafficserver.apache.org by "JosiahWI (via GitHub)" <gi...@apache.org> on 2023/06/12 13:14:25 UTC
[GitHub] [trafficserver] JosiahWI opened a new pull request, #9828: Add brotli support to CMake build
JosiahWI opened a new pull request, #9828:
URL: https://github.com/apache/trafficserver/pull/9828
This looks for the rotlicommon and brotlienc libraries. If they are found, it links both the brotlicommon and brotlienc libraries to the compress plugin.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] cmcfarlen commented on a diff in pull request #9828: Add brotli support to CMake build
Posted by "cmcfarlen (via GitHub)" <gi...@apache.org>.
cmcfarlen commented on code in PR #9828:
URL: https://github.com/apache/trafficserver/pull/9828#discussion_r1227292974
##########
include/tscore/ink_config.h.cmake.in:
##########
@@ -104,6 +104,7 @@ const int DEFAULT_STACKSIZE = @DEFAULT_STACK_SIZE@;
#define TS_MAX_HOST_NAME_LEN @TS_MAX_HOST_NAME_LEN@
/* Feature Flags */
+#cmakedefine01 HAVE_BROTLI_ENCODE_H
Review Comment:
Move this up with the other HAVE_ and make it just `#cmakedefine`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] cmcfarlen commented on a diff in pull request #9828: Add brotli support to CMake build
Posted by "cmcfarlen (via GitHub)" <gi...@apache.org>.
cmcfarlen commented on code in PR #9828:
URL: https://github.com/apache/trafficserver/pull/9828#discussion_r1228642873
##########
include/tscore/ink_config.h.cmake.in:
##########
@@ -32,6 +32,7 @@
#cmakedefine BUILD_GROUP "@BUILD_GROUP@"
#define BUILD_NUMBER "@BUILD_NUMBER@"
+#cmakedefine HAVE_BROTLI_ENCODE_H @HAVE_BROTLI_ENCODE_H@
Review Comment:
Lets just use `1` here like the rest of these
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] JosiahWI commented on a diff in pull request #9828: Add brotli support to CMake build
Posted by "JosiahWI (via GitHub)" <gi...@apache.org>.
JosiahWI commented on code in PR #9828:
URL: https://github.com/apache/trafficserver/pull/9828#discussion_r1228236268
##########
include/tscore/ink_config.h.cmake.in:
##########
@@ -104,6 +104,7 @@ const int DEFAULT_STACKSIZE = @DEFAULT_STACK_SIZE@;
#define TS_MAX_HOST_NAME_LEN @TS_MAX_HOST_NAME_LEN@
/* Feature Flags */
+#cmakedefine01 HAVE_BROTLI_ENCODE_H
Review Comment:
There are preprocessor directives that require it to be 0 or 1.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] JosiahWI commented on pull request #9828: Add brotli support to CMake build
Posted by "JosiahWI (via GitHub)" <gi...@apache.org>.
JosiahWI commented on PR #9828:
URL: https://github.com/apache/trafficserver/pull/9828#issuecomment-1587868393
[[ci approve autest]]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] JosiahWI commented on pull request #9828: Add brotli support to CMake build
Posted by "JosiahWI (via GitHub)" <gi...@apache.org>.
JosiahWI commented on PR #9828:
URL: https://github.com/apache/trafficserver/pull/9828#issuecomment-1590013361
[approve ci cmake]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] bneradt merged pull request #9828: Add brotli support to CMake build
Posted by "bneradt (via GitHub)" <gi...@apache.org>.
bneradt merged PR #9828:
URL: https://github.com/apache/trafficserver/pull/9828
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] bneradt commented on pull request #9828: Add brotli support to CMake build
Posted by "bneradt (via GitHub)" <gi...@apache.org>.
bneradt commented on PR #9828:
URL: https://github.com/apache/trafficserver/pull/9828#issuecomment-1589795993
[approve ci centos]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] JosiahWI commented on pull request #9828: Add brotli support to CMake build
Posted by "JosiahWI (via GitHub)" <gi...@apache.org>.
JosiahWI commented on PR #9828:
URL: https://github.com/apache/trafficserver/pull/9828#issuecomment-1587868709
[approve ci autest]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org