You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Stephan Erb <st...@dev.static-void.de> on 2015/04/04 11:25:34 UTC
Review Request 32861: Increase executor resource epsilon to match the
minimum required by Mesos
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32861/
-----------------------------------------------------------
Review request for Aurora.
Repository: aurora
Description
-------
Increase executor resource epsilon to match the minimum required by Mesos.
Mesos issues warnings for executors with <32MB RAM. By increasing the epsilon in Aurora, we shift some resources from the task to the executor. However, the total resources per container remains constant.
Diffs
-----
src/main/java/org/apache/aurora/scheduler/async/GcExecutorLauncher.java f55d1f4fff4724b0fb651b6f0dc10d2e8f62beff
src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java 8ae68653427c0bdbf33751d5ed4b74afcaf98a7b
Diff: https://reviews.apache.org/r/32861/diff/
Testing
-------
./gradlew -Pq build
Thanks,
Stephan Erb
Re: Review Request 32861: Increase executor resource epsilon to match
the minimum required by Mesos
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32861/#review78889
-----------------------------------------------------------
Master (27a602d) is green with this patch.
./build-support/jenkins/build.sh
However, it appears that it might lack test coverage.
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On April 4, 2015, 9:33 a.m., Stephan Erb wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32861/
> -----------------------------------------------------------
>
> (Updated April 4, 2015, 9:33 a.m.)
>
>
> Review request for Aurora.
>
>
> Bugs: AURORA-1246
> https://issues.apache.org/jira/browse/AURORA-1246
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Increase executor resource epsilon to match the minimum required by Mesos.
>
> Mesos issues warnings for executors with <32MB RAM. By increasing the epsilon in Aurora, we shift some resources from the task to the executor. However, the total resources per container remains constant.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/async/GcExecutorLauncher.java f55d1f4fff4724b0fb651b6f0dc10d2e8f62beff
> src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java 8ae68653427c0bdbf33751d5ed4b74afcaf98a7b
>
> Diff: https://reviews.apache.org/r/32861/diff/
>
>
> Testing
> -------
>
> ./gradlew -Pq build
>
>
> Thanks,
>
> Stephan Erb
>
>
Re: Review Request 32861: Increase executor resource epsilon to match
the minimum required by Mesos
Posted by Zameer Manji <zm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32861/#review79280
-----------------------------------------------------------
Ship it!
Ship It!
- Zameer Manji
On April 4, 2015, 2:33 a.m., Stephan Erb wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32861/
> -----------------------------------------------------------
>
> (Updated April 4, 2015, 2:33 a.m.)
>
>
> Review request for Aurora.
>
>
> Bugs: AURORA-1246
> https://issues.apache.org/jira/browse/AURORA-1246
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Increase executor resource epsilon to match the minimum required by Mesos.
>
> Mesos issues warnings for executors with <32MB RAM. By increasing the epsilon in Aurora, we shift some resources from the task to the executor. However, the total resources per container remains constant.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/async/GcExecutorLauncher.java f55d1f4fff4724b0fb651b6f0dc10d2e8f62beff
> src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java 8ae68653427c0bdbf33751d5ed4b74afcaf98a7b
>
> Diff: https://reviews.apache.org/r/32861/diff/
>
>
> Testing
> -------
>
> ./gradlew -Pq build
>
>
> Thanks,
>
> Stephan Erb
>
>
Re: Review Request 32861: Increase executor resource epsilon to match
the minimum required by Mesos
Posted by Zameer Manji <zm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32861/#review79279
-----------------------------------------------------------
Would you mind adding myself and wfarner as reviewers to this?
- Zameer Manji
On April 4, 2015, 2:33 a.m., Stephan Erb wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32861/
> -----------------------------------------------------------
>
> (Updated April 4, 2015, 2:33 a.m.)
>
>
> Review request for Aurora.
>
>
> Bugs: AURORA-1246
> https://issues.apache.org/jira/browse/AURORA-1246
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Increase executor resource epsilon to match the minimum required by Mesos.
>
> Mesos issues warnings for executors with <32MB RAM. By increasing the epsilon in Aurora, we shift some resources from the task to the executor. However, the total resources per container remains constant.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/async/GcExecutorLauncher.java f55d1f4fff4724b0fb651b6f0dc10d2e8f62beff
> src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java 8ae68653427c0bdbf33751d5ed4b74afcaf98a7b
>
> Diff: https://reviews.apache.org/r/32861/diff/
>
>
> Testing
> -------
>
> ./gradlew -Pq build
>
>
> Thanks,
>
> Stephan Erb
>
>
Re: Review Request 32861: Increase executor resource epsilon to match
the minimum required by Mesos
Posted by Stephan Erb <st...@dev.static-void.de>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32861/
-----------------------------------------------------------
(Updated April 4, 2015, 11:33 a.m.)
Review request for Aurora.
Bugs: AURORA-1246
https://issues.apache.org/jira/browse/AURORA-1246
Repository: aurora
Description
-------
Increase executor resource epsilon to match the minimum required by Mesos.
Mesos issues warnings for executors with <32MB RAM. By increasing the epsilon in Aurora, we shift some resources from the task to the executor. However, the total resources per container remains constant.
Diffs
-----
src/main/java/org/apache/aurora/scheduler/async/GcExecutorLauncher.java f55d1f4fff4724b0fb651b6f0dc10d2e8f62beff
src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java 8ae68653427c0bdbf33751d5ed4b74afcaf98a7b
Diff: https://reviews.apache.org/r/32861/diff/
Testing
-------
./gradlew -Pq build
Thanks,
Stephan Erb