You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Michael Park <mp...@apache.org> on 2016/12/13 21:02:14 UTC
Review Request 54595: Introduced an `os::dup` abstraction in stout.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54595/
-----------------------------------------------------------
Review request for mesos and Daniel Pravat.
Repository: mesos
Description
-------
Introduced an `os::dup` abstraction in stout.
Diffs
-----
3rdparty/stout/include/Makefile.am fc020bbf65030eb69a42d5c402e38ecb145f4c0f
3rdparty/stout/include/stout/os.hpp cdcbbf488d110e33e796fb0b7414793391761abf
3rdparty/stout/include/stout/os/dup.hpp PRE-CREATION
3rdparty/stout/include/stout/os/posix/dup.hpp PRE-CREATION
3rdparty/stout/include/stout/os/windows/dup.hpp PRE-CREATION
Diff: https://reviews.apache.org/r/54595/diff/
Testing
-------
Thanks,
Michael Park
Re: Review Request 54595: Introduced an `os::dup` abstraction in
stout.
Posted by Daniel Pravat <dp...@outlook.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54595/#review159209
-----------------------------------------------------------
Ship it!
Ship It!
- Daniel Pravat
On Dec. 13, 2016, 9:02 p.m., Michael Park wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54595/
> -----------------------------------------------------------
>
> (Updated Dec. 13, 2016, 9:02 p.m.)
>
>
> Review request for mesos and Daniel Pravat.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Introduced an `os::dup` abstraction in stout.
>
>
> Diffs
> -----
>
> 3rdparty/stout/include/Makefile.am fc020bbf65030eb69a42d5c402e38ecb145f4c0f
> 3rdparty/stout/include/stout/os.hpp cdcbbf488d110e33e796fb0b7414793391761abf
> 3rdparty/stout/include/stout/os/dup.hpp PRE-CREATION
> 3rdparty/stout/include/stout/os/posix/dup.hpp PRE-CREATION
> 3rdparty/stout/include/stout/os/windows/dup.hpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/54595/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Michael Park
>
>
Re: Review Request 54595: Introduced an `os::dup` abstraction in
stout.
Posted by Michael Park <mp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54595/
-----------------------------------------------------------
(Updated Dec. 20, 2016, 2:30 p.m.)
Review request for mesos and Daniel Pravat.
Repository: mesos
Description
-------
Introduced an `os::dup` abstraction in stout.
Diffs (updated)
-----
3rdparty/stout/include/Makefile.am 53d04a9b6c4a0d8b35d3c84ef24d619fdb8a2c82
3rdparty/stout/include/stout/os.hpp 63265eed28d7345dfa18ac1c5a22ef58a7902c62
3rdparty/stout/include/stout/os/dup.hpp PRE-CREATION
3rdparty/stout/include/stout/os/posix/dup.hpp PRE-CREATION
3rdparty/stout/include/stout/os/windows/dup.hpp PRE-CREATION
Diff: https://reviews.apache.org/r/54595/diff/
Testing
-------
Thanks,
Michael Park
Re: Review Request 54595: Introduced an `os::dup` abstraction in
stout.
Posted by Michael Park <mp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54595/
-----------------------------------------------------------
(Updated Dec. 14, 2016, 3:52 p.m.)
Review request for mesos and Daniel Pravat.
Repository: mesos
Description
-------
Introduced an `os::dup` abstraction in stout.
Diffs (updated)
-----
3rdparty/stout/include/Makefile.am 56c44911ff7015d5825a93ce7a898a60c8624ee7
3rdparty/stout/include/stout/os.hpp 63265eed28d7345dfa18ac1c5a22ef58a7902c62
3rdparty/stout/include/stout/os/dup.hpp PRE-CREATION
3rdparty/stout/include/stout/os/posix/dup.hpp PRE-CREATION
3rdparty/stout/include/stout/os/windows/dup.hpp PRE-CREATION
Diff: https://reviews.apache.org/r/54595/diff/
Testing
-------
Thanks,
Michael Park